1624885 - Crash in [@ style::properties::{{impl}}::clone]

Status: RESOLVED WORKSFORME

(Core :: CSS Parsing and Computation, defect, P3)

Description

[Simon Giesecke [:sg] [he/him]]

This bug is for crash report bp-6e1cefe9-e19e-42c7-898f-dfec40200325.

Top 10 frames of crashing thread:

0 xul.dll style::properties::{{impl}}::clone x86_64-pc-windows-msvc/release/build/style-05fa5bee380c6dec/out/properties.rs:1675
1 xul.dll geckoservo::glue::Servo_DeclarationBlock_Clone servo/ports/geckolib/glue.rs:4231
2 xul.dll mozilla::DeclarationBlock::Clone const layout/style/DeclarationBlock.h:49
3 xul.dll mozilla::DeclarationBlock::EnsureMutable layout/style/DeclarationBlock.h
4 xul.dll nsDOMCSSDeclaration::ParsePropertyValue layout/style/nsDOMCSSDeclaration.cpp:309
5 xul.dll nsDOMCSSDeclaration::SetPropertyValue layout/style/nsDOMCSSDeclaration.cpp:90
6 xul.dll mozilla::dom::CSS2Properties_Binding::set_fontSize dom/bindings/CSS2PropertiesBinding.cpp:18269
7 xul.dll mozilla::dom::binding_detail::GenericSetter<mozilla::dom::binding_detail::NormalThisPolicy> dom/bindings/BindingUtils.cpp:3153
8 xul.dll js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:568
9 xul.dll js::CallSetter js/src/vm/Interpreter.cpp:786

This recently started occurring (again?) in Nightly build id 20200323213856. Not sure how many installations are affected, since the newer builds' crashes are missing an install date for some reason.

Comment 1

[Emily McDonough [:alaskanemily]]

Emilio, I remember you had looked at (or at least commented on) a similar bug before where it was suspected disk/file corruption occurring. Does this look like a similar situation?

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Yeah, this one is a bit different because it also has some (only two) win10 crashes. But the volume is similarly small (6 crashes across 3 releases).

If the crash is an issue in Firefox, the corruption has happened way earlier than the point of the crash. If not, it's likely it's external software messing with us...

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 4

[Firefox Bug Husbandry Bot]

Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3 (Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3 (normal.)

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.