Closed
Bug 1625075
Opened 4 years ago
Closed 4 years ago
Use HTMLInputElement.hasBeenTypePassword instead of `type` for login context menu items
Categories
(Toolkit :: Password Manager, task, P2)
Toolkit
Password Manager
Tracking
()
VERIFIED
FIXED
mozilla76
People
(Reporter: MattN, Assigned: MattN)
References
Details
(Whiteboard: [passwords:fill-ui])
Attachments
(1 file)
Bug 1551730 is using hasBeenTypePassword
for autocomplete and autofill. This bug should do the same for the context menu code.
Verification instructions:
Ensure that the proper context menu string "Fill Login" vs. "Fill password" when filling username and passwords fields with a password field website visibility toggle unmasking the field.
Flags: qe-verify+
Assignee | ||
Updated•4 years ago
|
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•4 years ago
|
||
- Remove usernameField from getFieldContext since it isn't used if we return the state of the specified field. Then we don't need the hacky override for usernameField depending on hasBeenTypePassword.
- Return early in LMP._onPasswordEditedOrGenerated if the tab closes to address a test failure in browser_context_menu.js.
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/787bd474422f Use HTMLInputElement.hasBeenTypePassword for the context menu. r=sfoster
Comment 3•4 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
Comment 4•4 years ago
|
||
Verified-fixed on latest Firefox Nightly 76.0a1 (2020-04-06) on Windows 10, MacOS 10.13 and Ubuntu 16.04.
The "Fill login", "Fill Password" and Generate Password options are correctly displayed in the context menu when the password field on a form is unmasked.
You need to log in
before you can comment on or make changes to this bug.
Description
•