Closed Bug 1625207 Opened 5 years ago Closed 5 years ago

Make `device_manufacturer` in client info optional

Categories

(Data Platform and Tools :: Glean: SDK, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: janerik, Assigned: janerik)

References

Details

(Whiteboard: [telemetry:fog:m3])

Attachments

(2 files, 1 obsolete file)

With us moving away from mobile it's not super clear anymore what device we're talking about, making the device_manufacturer field less useful.

It should be made optional in the schema so FOG can send pings without it.

Assignee: nobody → jrediger
Priority: P3 → P2
Whiteboard: [telemetry:glean-rs:m?]
Whiteboard: [telemetry:fog:m3]

While I am not currently working with Desktop data, knowing one's device is a useful data point for troubleshooting differences in performance or behavior. I would like to keep this in Glean as a mandatory field unless it isn't possible to include for technical reasons.

I think on Desktop there isn't the same situation. For my laptop, the device manufacturer is Lenovo. But that doesn't tell you much as my wife's work laptop is also a Lenovo and wow is it a different beast. Knowing the model might help, but there are variations you can buy (different RAM amounts, SSD vs spinning disk). It isn't uniform in the way that knowing a phone is a Pixel 2 tells you approximately everything about the HW you need to know.

(( It's even worse on desktop where the pieces come from all over. My GPU's from nvidia, my CPU's Intel, the motherboard is... I think ASUS? Not sure. And the case is some noname box of metal and plastic. ))

I think it should be made optional in the schema.

Attached file GitHub Pull Request (obsolete) —
Priority: P2 → P1
Attachment #9137085 - Attachment is obsolete: true
Blocks: 1626303
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Blocks: 1672184
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: