Closed Bug 1625246 Opened 4 months ago Closed 4 months ago

Make tabindex-focus-flag.html iframe test pass on try server

Categories

(Core :: DOM: UI Events & Focus Handling, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: edgar, Assigned: edgar)

Details

Attachments

(1 file)

See https://searchfox.org/mozilla-central/source/testing/web-platform/meta/html/interaction/focus/tabindex-focus-flag.html.ini.

The reason that we could not pass the iframe test on try server is because the sub-document isn't ready yet while trying to focus the iframe, nsContentUtils::IsSubDocumentTabbable returns false in https://searchfox.org/mozilla-central/rev/b712398b7fae54ef377a558d6f16dede7a7f8530/dom/base/nsContentUtils.cpp#6201-6203

But we could pass this test if we run it manually on https://w3c-test.org/html/interaction/focus/tabindex-focus-flag.html.

It is kinda racing between test and page load.
I think we should wait load event first before starting tests.

Found an issue while running this test on Firefox automation server: test tries
to focus iframe before the iframe is ready to be focused. We should wait for load
event to ensure page is ready for testings.

Assignee: nobody → echen
Status: NEW → ASSIGNED
Pushed by echen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fadc1360393f
Make tabindex-focus-flag.html wait load event first before starting tests; r=smaug
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/22483 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Upstream PR merged by moz-wptsync-bot
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.