1625260 - When opening a draft message, enigmail code thinks composer is dirty, despite no changes

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Kai Engert (:KaiE:)]

This test fails with the enigmail code enabled:
comm/mail/test/browser/composition/browser_draftIdentity.js

This is caused by a difference how a message is treated, that was opened from a draft message.

Steps to reproduce:

• compose a message
• save as draft
• close message
• find message in draft folder
• click the edit button
• in the compose that opened, use file close

Expected behavior:
Composer window gets closed immediately, no prompt.
(That makes sense, nothing in composer was changed.)

Actual behavior with Enigmail code enabled:
A prompt is shown to confirm that the user wants to discard the message.

This behavior is independent of saying drafts as plain text or encrypted, and can be reproduced with TB 68 and enigmail, too, as well an with the latest nightly code.

Comment 1

[Kai Engert (:KaiE:)]

also affects:
comm/mail/test/browser/composition/browser_saveChangesOnQuit.js

Comment 2

[Kai Engert (:KaiE:)]

The Enigmail code always updates the message subject when opening a draft message, regardless if the loaded subject needs to be replaced or not. Then it calls subject.oninput() which unconditionally sets the gContentChanged variable.

A fix is to avoid updating the subject if it's unnecessary.

Comment 3

[Kai Engert (:KaiE:)]

Attachment: 1625260-v1.patch

Comment 4

[Patrick Brunschwig]

Comment on attachment 9136326 [details] [diff] [review]
1625260-v1.patch

Review of attachment 9136326 [details] [diff] [review]:
-----------------------------------------------------------------

There is still an unnecessary console.debug() statement.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9e8aed12d503
Avoid unnecessary dirty message state after draft message. r=PatrickBrunschwig DONTBUILD