Closed Bug 1625295 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 22482 - [AspectRatio] Add parsing support for aspect-ratio: X / Y

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla76
Tracking Flags:
Tracking Status
firefox76 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 22482 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22482
Details from upstream follow.

Christian Biesinger <cbiesinger@chromium.org> wrote:

[AspectRatio] Add parsing support for aspect-ratio: X / Y

Does not use the property in layout yet.

https://drafts.csswg.org/css-sizing-4/#aspect-ratio

Bug: 1045668
Change-Id: I1c6411faaf7eec6c7dc041da5b7e481fb34fe030
Reviewed-on: https://chromium-review.googlesource.com/2122430
WPT-Export-Revision: 57143c555287d9c1841a5be728363f25f80475c3

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 13 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 50 tests

Status Summary

Firefox

OK : 3
PASS: 8[GitHub] 55[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-linux1804-64-asan-opt, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt]
FAIL: 9

Chrome

OK : 3
PASS: 8
FAIL: 9

Safari

OK : 3
PASS: 8
FAIL: 9

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-sizing/aspect-ratio/parsing/contain-intrinsic-size-valid.html
e.style['aspect-ratio'] = "16/ 9" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['aspect-ratio'] = "16 /9" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['aspect-ratio'] = "16 / 9" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['aspect-ratio'] = "auto" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
e.style['aspect-ratio'] = "16/9" should set the property value: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-sizing/aspect-ratio/parsing/contain-intrinsic-size-computed.html
Property aspect-ratio value '16/9': FAIL (Chrome: FAIL, Safari: FAIL)
Property aspect-ratio value '16 / 9': FAIL (Chrome: FAIL, Safari: FAIL)
Property aspect-ratio value '1 / 1': FAIL (Chrome: FAIL, Safari: FAIL)
Property aspect-ratio value 'auto': FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3947c119e121
[wpt PR 22482] - [AspectRatio] Add parsing support for aspect-ratio: X / Y, a=testonly
https://hg.mozilla.org/integration/autoland/rev/672691a8e2a7
[wpt PR 22482] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/3947c119e121
https://hg.mozilla.org/mozilla-central/rev/672691a8e2a7

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox76: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.