Closed
Bug 1625417
Opened 5 years ago
Closed 2 years ago
Refactor DOM.describeNode and DOM.resolveNode to use a number as nodeId and backendNodeId
Categories
(Remote Protocol :: CDP, defect, P3)
Remote Protocol
CDP
Tracking
(firefox112 fixed)
RESOLVED
FIXED
112 Branch
| Tracking | Status | |
|---|---|---|
| firefox112 | --- | fixed |
People
(Reporter: whimboo, Assigned: canadahonk)
References
Details
Attachments
(1 file)
The basic implementation of DOM.describeNode and DOM.resolveNode uses a uuid for the nodeId and backendNodeId identifier. This was easier to do, but would need a refactoring to be CDP compliant, which actually expects a number.
|
||
Comment 1•4 years ago
|
||
Because this bug's Severity has not been changed from the default since it was filed, and it's Priority is P3 (Backlog,) indicating it has been triaged, the bug's Severity is being updated to S3 (normal.)
Severity: normal → S3
|
||
Updated•4 years ago
|
Component: CDP: DOM → CDP
|
Assignee | |
Comment 2•2 years ago
|
||
Minor refactor to use a number as nodeId instead of a UUID string. Also
fixed tests expecting number to be an invalid type and string to be
valid instead.
|
||
Updated•2 years ago
|
Assignee: nobody → oj
Status: NEW → ASSIGNED
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ff30ca2f39f6
[cdp] Use number as nodeId for DOM methods r=webdriver-reviewers,jdescottes
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox112:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•