Closed Bug 1625662 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 22506 - Fix rounding in DelayNode buffer size calculation

Categories

(Core :: Web Audio, task, P4)

Product:
Core
Component:
Web Audio
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla76
Tracking Flags:
Tracking Status
firefox76 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 22506 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22506
Details from upstream follow.

Michael Constant <mconst@gmail.com> wrote:

Fix rounding in DelayNode buffer size calculation

DelayNode needs to buffer maxDelayTime worth of sample frames,
plus one for interpolation. If maxDelayTime isn't an integer
number of frames, we have to round it up -- otherwise the buffer
ends up one frame too short, causing the interpolation to wrap
around and access the newest input instead of the oldest.

Bug: 1065110
Change-Id: Ia47dbd07c3b3b48734c03442a020d76a680eaaa0
Reviewed-on: https://chromium-review.googlesource.com/2122852
WPT-Export-Revision: c9cf4a372856607d4c334d4fe978b11cd7c0c163

Component: web-platform-tests → Web Audio
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 11 subtests

Status Summary

Firefox

OK : 1
PASS: 8

Chrome

OK : 1
PASS: 5
FAIL: 3

Safari

OK : 1
PASS: 4
FAIL: 1

Links

GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/16b60e3013ad
[wpt PR 22506] - Fix rounding in DelayNode buffer size calculation, a=testonly

https://hg.mozilla.org/mozilla-central/rev/16b60e3013ad

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox76: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in before you can comment on or make changes to this bug.