Closed Bug 1625675 Opened 4 years ago Closed 4 years ago

need an icon128.png following bug 1624865

Categories

(Thunderbird :: Theme, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 76.0

People

(Reporter: mkmelin, Assigned: mkmelin)

Details

Attachments

(2 files)

Following bug 1624865 we need an map and icon128.png https://hg.mozilla.org/mozilla-central/rev/ea13cc098fe95ab76f3bd1d52f5b0b09ba15c529

This is causing some failures for
./mach test comm/mail/test/static/browser_parsable_css.js

Summary: need and icon128.png → need an icon128.png following bug 1624865

Fixes the test at least locally.
I'm no 100% sure we need the addition in allowed-dupes.mn but I forgot how we test if that's needed.

Attachment #9136548 - Flags: review?(richard.marti)
Status: NEW → ASSIGNED
Comment on attachment 9136548 [details] [diff] [review]
bug1625675_icon128.patch

Looks good. The allowed-dupes.mn shouldn't be needed as there is no second 128 px icon to package.  You can test the packaging with `mach package`.
Attachment #9136548 - Flags: review?(richard.marti) → review+

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/a3d09401552d
need an icon128.png following bug 1624865. r=Paenglab

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED

Strange. I removed it from allowed-dupes.mn and mach package worked fine locally. On CI linux builds fail:

[task 2020-03-28T22:44:23.809Z] 22:44:23 INFO - package> ERROR: The following duplicated files are not allowed:
[task 2020-03-28T22:44:23.809Z] 22:44:23 INFO - package> chrome/icons/default/default128.png
[task 2020-03-28T22:44:23.809Z] 22:44:23 INFO - package> chrome/messenger/content/branding/icon128.png
[task 2020-03-28T22:44:23.810Z] 22:44:23 INFO - package> /builds/worker/checkouts/gecko/toolkit/mozapps/installer/packager.mk:25: recipe for target 'stage-package' failed

I'll push a followup for that.

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/1da13833761b
followup - add icon128.png to allowed-dupes.mn (to make linux CI builds succeed). rs=bustage-fix DONTBUILD

Ah, only Linux uses the default128.png. Could you also add the default128.png to the allowed-dupes.mn? Then it's also clearer which ones are the dupes.

Attachment #9136602 - Flags: review?(richard.marti)
Target Milestone: --- → Thunderbird 76.0
Attachment #9136602 - Flags: review?(richard.marti) → review+
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/082497e9e8f0
followup2 - add default128.png too to allowed-dupes.mn (also needed for linux CI not to fail). r=Paenglab
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: