Closed Bug 1625753 Opened 4 years ago Closed 4 years ago

Fix context menu for BiDi

Categories

(SeaMonkey :: General, defect)

Product:
SeaMonkey
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(seamonkey2.49esr unaffected, seamonkey2.53 fixed, seamonkey2.57esr fixed)

Status:
RESOLVED FIXED
Milestone:
seamonkey 2.73
Tracking Flags:
Tracking Status
seamonkey2.49esr --- unaffected
seamonkey2.53 --- fixed
seamonkey2.57esr --- fixed

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

(Regression)

Details

(Whiteboard: SM2.53.2)

Attachments

(1 file)

Fix the variable name
1.32 KB, patch
frg
: review+
frg
: approval-comm-release+
frg
: approval-comm-esr60+
Details | Diff | Splinter Review

Bug 1578062 introduced a regression in using gBidiUI rather than gShowBiDi in some parts of the context menu code.

[Approval Request Comment]
Regression caused by (bug #): 1578062
User impact if declined: potential issues with context menus
Testing completed (on m-c, etc.): 2.53.2
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Attachment #9136611 - Flags: review?(frgrahl)
Attachment #9136611 - Flags: approval-comm-release?
Attachment #9136611 - Flags: approval-comm-esr60?
Comment on attachment 9136611 [details] [diff] [review]
Fix the variable name

LGTM
Might need a backport of Bug 370777 later.
Attachment #9136611 - Flags: review?(frgrahl)
Attachment #9136611 - Flags: review+
Attachment #9136611 - Flags: approval-comm-release?
Attachment #9136611 - Flags: approval-comm-release+
Attachment #9136611 - Flags: approval-comm-esr60?
Attachment #9136611 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/83dced891b54
Fix context menu for BiDi. r=frg

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
status-seamonkey2.49esr: --- → unaffected
status-seamonkey2.53: --- → affected
status-seamonkey2.57esr: --- → affected
Target Milestone: --- → seamonkey 2.73
status-seamonkey2.53: affected → fixed
status-seamonkey2.57esr: affected → fixed
Whiteboard: SM2.53.2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: