1625850 - Crash in [@ nsGNOMEShellSearchProvider::LaunchWithID]

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Gabriele Svelto [:gsvelto] (PTO)]

This bug is for crash report bp-0fbe6c56-64ba-4fac-9415-51fd30200329.

Top 10 frames of crashing thread:

0 libxul.so nsGNOMEShellSearchProvider::LaunchWithID /builddir/build/BUILD/firefox-74.0/browser/components/shell/nsGNOMEShellSearchProvider.cpp:560
1 libxul.so nsGNOMEShellSearchProvider::ActivateResult /builddir/build/BUILD/firefox-74.0/browser/components/shell/nsGNOMEShellSearchProvider.cpp:639
2 libdbus-1.so.3.19.11 _dbus_object_tree_dispatch_and_unlock ../../dbus/dbus-object-tree.c:1020
3 libdbus-1.so.3.19.11 <name omitted> ../../dbus/dbus-connection.c:4576
4 libdbus-glib-1.so.2.3.4 message_queue_dispatch /usr/src/debug/dbus-glib-0.110-6.fc31.x86_64/dbus-gmain/dbus-gmain.c:89
5 libglib-2.0.so.0.6200.6 <name omitted> ../glib/gmain.c:3881
6 libglib-2.0.so.0.6200.6 g_main_context_iterate ../glib/gmain.c:3954
7 libglib-2.0.so.0.6200.6 <name omitted> ../glib/gmain.c:4015
8 libxul.so nsAppShell::ProcessNextNativeEvent /builddir/build/BUILD/firefox-74.0/widget/gtk/nsAppShell.cpp:274
9 libxul.so nsBaseAppShell::DoProcessNextNativeEvent /builddir/build/BUILD/firefox-74.0/widget/nsBaseAppShell.cpp:120

I'm not sure if this the right component. The crash seems Fedora-specific. One user left a comment that looks like a useful STR:

Here is the way I can reproduce this crash: I have firefox open. I press the super key going navigating to Gnome search. I miss-spell 'slakc' + enter (The last step needs to be done fast, when I do it slow, nothing happens, specially the sequence of the last characters and pressing enter, like kc[Enter]) Then firefox crashes! 

I'm also CC'ing users who reported this and have a bugzilla account.

Comment 1

[Sanqui]

Another Fedora user here, I can confirm that I'm having Firefox crash sometimes when using Gnome search quickly and making a typo, as odd as it sounds.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

I guess it's because keyIndex at nsGNOMEShellSearchProvider::LaunchWithID() is invalid so we get null nsCOMPtr<nsINavHistoryResultNode> child
and then crash at child->GetUri(uri);
Let's fix that in next iteration of Bug 1239694.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Should be fixed by Bug 1239694.