Closed
Bug 1625861
Opened 4 years ago
Closed 4 years ago
Promise.cpp's "MaybeNow" is stale WebReplay code and can be deleted
Categories
(Core :: JavaScript Engine, task, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla76
| Tracking | Status | |
|---|---|---|
| firefox76 | --- | fixed |
People
(Reporter: loganfsmyth, Assigned: loganfsmyth)
Details
Attachments
(1 file)
Promise.cpp has a MaybeNow function that always returns Nothing(). It's an unnecessary function that only exists because it used to return Some() when WebReplay was active. https://searchfox.org/mozilla-central/rev/9c6e7500c0015a2c60be7b1b888261d95095ce27/js/src/builtin/Promise.cpp#393
|
Assignee | |
Comment 1•4 years ago
|
||
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
||
Updated•4 years ago
|
Priority: -- → P1
Pushed by loganfsmyth@gmail.com: https://hg.mozilla.org/integration/autoland/rev/0e780f94d2b2 Delete stale WebReplay code in Promise.cpp. r=arai
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox76:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
You need to log in
before you can comment on or make changes to this bug.
Description
•