1625933 - fail to run mach try fuzzy -u

Status: RESOLVED FIXED

(Developer Infrastructure :: Try, defect)

Description

[Andy Wingo [:wingo]]

Just updated my central branch after a few weeks, and I now have this:

wingo@milano:~/src/mozilla-unified$ MOZCONFIG=+debug-mozconfig ./mach try fuzzy -u
Error running mach:

    ['try', 'fuzzy', '-u']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

AttributeError: 'NoneType' object has no attribute 'startswith'

  File "/home/wingo/src/mozilla-unified/tools/tryselect/mach_commands.py", line 307, in try_fuzzy
    return self.run(**kwargs)
  File "/home/wingo/src/mozilla-unified/tools/tryselect/mach_commands.py", line 177, in run
    return mod.run(**kwargs)
  File "/home/wingo/src/mozilla-unified/tools/tryselect/selectors/fuzzy.py", line 306, in run
    fzf = fzf_bootstrap(update)
  File "/home/wingo/src/mozilla-unified/tools/tryselect/selectors/fuzzy.py", line 231, in fzf_bootstrap
    if update and not fzf_bin.startswith(fzf_path):

Looking at the log I see there are changes recently:

wingo@milano:~/src/mozilla-unified$ git log tools/tryselect/selectors/fuzzy.py
commit de68f270fda9dc960db689f6e806b1dbfa72df13
Author: Simon Fraser <[e-mail]>
Date:   Wed Mar 25 10:07:26 2020 +0000

    Bug 1623197 Change fzf management check to avoid side effects r=ahal
    
    Differential Revision: https://phabricator.services.mozilla.com/D67830

commit 1ff368082e7a88760de914002be9d5e956f7edfd
Author: Simon Fraser <[e-mail]>
Date:   Thu Mar 12 12:56:35 2020 +0000

    Bug 1621658 Update |mach try fuzzy| fzf version check r=ahal
    
    Add filename support for plain display
    
    Update fzf version in tests
    
    Update tooltool url for fzf
    
    Differential Revision: https://phabricator.services.mozilla.com/D66571

Comment 1

[Andy Wingo [:wingo]]

FYI I had just done a fresh mach bootstrap

Comment 2

[Simon Fraser [:sfraser] ⌚️GMT]

Attachment: Bug 1625933 Only complain about unmanaged fzf if it was found

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3a4dd52d4e0
Only complain about unmanaged fzf if it was found r=ahal

Comment 4

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/f3a4dd52d4e0