1625979 - Having the width of Firefox very narrow results in cutting the preview themes by the search bar upon scroll

Status: RESOLVED DUPLICATE of bug 1623652

(Toolkit :: Add-ons Manager, defect)

Description

[Bogdan Maris, Desktop Test Engineering]

Attachment: Screencast showing the issue

Affected versions

• Firefox 74.0
• Firefox 75.0b10
• Latest Nightly 76.0a1

Affected platforms

• Windows 10 64bit
• Ubuntu 18.04 64bit
• MacOS 10.15

Steps to reproduce

1. Start Firefox
2. Visit about:addons / Themes
3. Resize width of Fx until a horizontal scroll appears
4. Move the scrollbar to far right
5. Scroll the page up and down

Expected result

• No visual defects can be seen.

Actual result

• Search bar cuts the theme preview image.

Regression range

• This is not a regression since this behavior resulted after changing the design of about:addons

• First build where this started is in this bug:

• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=90583a5ead34b46c110a78b9f74c2af9a16dafe9&tochange=8a261afd573a9c8b73865e9e10858377a2092aee

• Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1525175

• Here it got more obvious:

• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b76cec570edf11c26990453d351a98901061953d&tochange=007007b06317aba21a5d445dbc38dd6fee0811b0

• Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1575905

Comment 1

[Mark Striemer [:mstriemer]]

Can you check again on today's Nightly? I landed a patch last night that moved the sidebar to the HTML document which also moved to a grid layout for the sidebar/main content layout.

I can't reproduce on Windows right now.

Comment 2

[Bogdan Maris, Desktop Test Engineering]

Hm, I can't reproduce as well across platforms (Windows 10 64bit, Ubuntu 18.04 64bit and macOS 10.15.4) but I do see some inconsistency between about: pages. For example in about:preferences the sidebar does not move once I resize the width of Fx.

Do you know if there a plan to change all the about: pages? There should be a consistency between all about: pages.

Comment 3

[Mark Striemer [:mstriemer]]

Attachment: about-addons-sidebar-move-on-scroll.mp4

What's the sidebar moving issue?

I didn't notice anything on my Mac, but tried on Windows and looks like when the horizontal scrollbar is visible the sidebar is too tall. I'm not sure that's the same issue though.

I would like to see more consistency between the about: pages. I'll look into matching the sidebars more closely in the future but there could still be some differences with about:preferences since it's still in XUL and things layout slightly differently.

Comment 4

[Bogdan Maris, Desktop Test Engineering]

Attachment: Tools sidebar

I was referring on the sidebar that has the shortcuts for addons menus and preferences as well (don't know the actual name of it).

Comment 5

[Mark Striemer [:mstriemer]]

I think this will be fixed by bug 1623652 which was originally a workaround for some RTL issues but looks like it should be done for LTR as well to solve this issue.