1626016 - Move postData inside URIFixupInfo

Status: RESOLVED FIXED

(Core :: DOM: Navigation, task, P3)

Description

[Marco Bonardo [:mak]]

Follow-up to bug 1496578, currently postData is passed as an optional out argument, it could instead be passed as part of the URIFixupInfo object.

Comment 1

[Marco Bonardo [:mak]]

Even if we move postData inside fixupInfo, createFixupURI would still require an optional out argument. The alternative would be to convert all of its callers to getFixupURIInfo, that is more verbose:
https://searchfox.org/mozilla-central/search?q=createFixupURI

Comment 2

[:Gijs (he/him)]

(In reply to Marco Bonardo [:mak] from comment #1)

Even if we move postData inside fixupInfo, createFixupURI would still require an optional out argument. The alternative would be to convert all of its callers to getFixupURIInfo, that is more verbose:
https://searchfox.org/mozilla-central/search?q=createFixupURI

I mean, from JS it's not that much more verbose...

let postData = {};
let uri = urifixup.createFixupURI(... , postData);

vs

let {uri, postData} = urifixup.getFixupURIInfo(...);

From C++, I agree it'd probably be worse. But then, I think we should stop calling it in C++ anyway...

Comment 3

[Marco Bonardo [:mak]]

Attachment: Bug 1626016 - Remove createFixupURI and move postData inside URIFixupInfo. r=gijs

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb5f75652512
Remove createFixupURI and move postData inside URIFixupInfo. r=Gijs,geckoview-reviewers,preferences-reviewers,snorp

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/bb5f75652512

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9d42c3bec073
Port bug 1626016 - Remove nsIURIFixup.createFixupURI. rs=bustage-fix