1626057 - Implement TRR steering platform APIs

Status: RESOLVED FIXED

(Core :: Networking: DNS, task, P2)

Description

[Valentin Gosu [:valentin] (he/him)]

We need the rollout addon to be able to query a DNS name and map the CNAME response to one of the TRR URIs in our list.
That URI should be used for that network, if no user choices are present that say it shouldn't be used.

Comment 1

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1626057 - Add experiments.heuristics.setDetectedTrrURI API r=dragana

Comment 2

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1626057 - Implement TRRService::SetDetectedTrrURI r=dragana

Depends on D68874

Comment 3

[Valentin Gosu [:valentin] (he/him)]

TBD:

• who checks that we don't overwrite a user set trr.uri pref?
  Should we do it in the addon or platform? I assume it should be the platform, but it's unclear how we would differentiate trr.uri set by the user, from trr.uri set by the rollout, when we start migrating users to other providers. We need to figure out a way to do that.
• who resets the URI on network change?
  Again, I assume it would be the platform, and the addon just runs heuristics again, and if needed calls the method again. During this time we'd be using the "default" URI.

Comment 4

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1626057 - [WIP] doh-rollout steering detection r=dragana

Comment 5

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1626057 - Ignore setDetectedTrrURI when the user has set the TRR URI r=dragana

Depends on D68889

Comment 6

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1626057 - Reset TRRService::mPrivateURI on network changes r=dragana

Depends on D69372

Comment 7

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1626057 - Check for the existence of doh-rollout.uri r=dragana

Considering that we want to have multiple default TRR providers that are
chosen by the doh-rollout addon, it becomes too complex for the addon
to keep track of all of the prefs it changes, while at the same time
figuring out if the user has ever touched the same prefs.

As such, we will make the distinction that doh-rollout.uri is only
set by the rollout addon, and network.trr.uri is only set by user action.
So, when the any of the uri prefs change, we choose them like this:

1. The user provider URI
2. The addon chosen URI
3. The default pref URI

Depends on D69373

Comment 8

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1626057 - Send an observer notification when the TRR URI changes r=dragana

This patch also exposes nsIDNSService.currentTrrURI to be used by the UI
to display the URI currently in use by the TRR service.

Depends on D71659

Comment 9

[Valentin Gosu [:valentin] (he/him)]

Attachment: Bug 1626057 - Add test for TRRService URI change notifications r=dragana

Depends on D71660

Comment 10

[Phabricator Automation]

Comment on attachment 9136919 [details]
Bug 1626057 - [WIP] doh-rollout steering detection r=dragana

Revision D68889 was moved to bug 1631609. Setting attachment 9136919 [details] to obsolete.

Comment 11

[Andreea Pavel [:apavel]]

Stack landed here:
https://hg.mozilla.org/integration/autoland/rev/6dd561a7356b5ebccf996949fa39d420ef169cc3
https://hg.mozilla.org/integration/autoland/rev/a0a204057df224e513bab2ec9caaa2eb74749930
https://hg.mozilla.org/integration/autoland/rev/fad0c0132989cd59aa5cecccbd3b22f700c88d0a
https://hg.mozilla.org/integration/autoland/rev/7dc18bc57d2da0470400ea20ab1aaa2be4a2bd16
https://hg.mozilla.org/integration/autoland/rev/39f442a65b2b4a260ef300f375c25aa69874f45a
https://hg.mozilla.org/integration/autoland/rev/557d17bfcb062818e4bd88f8339eb4d3defe0678
https://hg.mozilla.org/integration/autoland/rev/f9872d8527bc85fb4746cf376be4bf07b3c63181

TH link: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=6dd561a7356b5ebccf996949fa39d420ef169cc3

Comment 12

[Andreea Pavel [:apavel]]

Merged: https://hg.mozilla.org/mozilla-central/pushloghtml?changeset=cdd14a1df784642f8741b0f76041e92ba99ec9df