1626063 - Implement Personal Data Promise onboarding cad

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Punam Dahiya [:pdahiya]]

Scope of this bug is to add a new 'Personal Data Promise' onboarding card to be used in pull factor reinforcement experiment

Comment 1

[Punam Dahiya [:pdahiya]]

https://docs.google.com/document/d/1PTYHCVI7UGN1X8nidfZYbxHs8PHMIYPczu82teJbuFE/edit?ts=5e7e4969#

Personal Data Promise
Header: Private by Design
Body: Firefox treats your data with respect by taking less of it, protecting it, and being clear about how we use it.
CTA: Read our Promise
which icon to reuse <aaron>
URL: https://www.mozilla.org/en-US/firefox/privacy/ (locale-specific)
Note: a separate Privacy Notice opens in a second tab (which is fine), the URL is very similar

Comment 2

[Punam Dahiya [:pdahiya]]

Scope of this fix is to Add Header,Body and CTA strings in onboarding.ftl to pass respective data-l10n-id remotely.

Eventually we should change OnboardingMessage to use MSLocalized component similar to HeroText and StartBrowsing button
in aboutwelcome.jsx which will give us flexibility to set text remotely

https://searchfox.org/mozilla-central/source/browser/components/newtab/content-src/asrouter/templates/OnboardingMessage/OnboardingMessage.jsx#34

https://searchfox.org/mozilla-central/source/browser/components/newtab/content-src/aboutwelcome/aboutwelcome.jsx#61

Comment 3

[Punam Dahiya [:pdahiya]]

Attachment: Bug 1626063 - Implement Personal Data Promise card

Comment 4

[Punam Dahiya [:pdahiya]]

Hi Hector,
As you have worked on https://bugzilla.mozilla.org/show_bug.cgi?id=1618475, NI you to keep you posted about this patch. With this fix, setting 'trailhead.firstrun.branches' pref to 'privacy' is going to show set of privacy triplet cards on about:newtab. Please let me know if you have any questions. Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c3dc78d776d
Implement Personal Data Promise card r=fluent-reviewers,andreio,flod

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/4c3dc78d776d

Comment 7

[Hector Zhao [:hectorz]]

(In reply to Punam Dahiya [:pdahiya] from comment #4)

Hi Hector,
As you have worked on https://bugzilla.mozilla.org/show_bug.cgi?id=1618475, NI you to keep you posted about this patch. With this fix, setting 'trailhead.firstrun.branches' pref to 'privacy' is going to show set of privacy triplet cards on about:newtab. Please let me know if you have any questions. Thanks!

Hi Punam,

Thanks for notifying me about this change.

With join-privacy marked as "Supported in 71 only" 1 and bug 1618475 being part of Fx 75, we're switching the trailhead.firstrun.branches pref to join-dynamic in our distribution.ini file 2. As a result, we're showing "browse privately", "mobile phone" and "send tabs" for now. So this change shouldn't affect us in any way.

Comment 8

[Marius Coman [:mcoman], Ecosystem QA]

I have verified, that the "Personal Data Promise" card is displayed in the "about:newtab" page if the "trailhead.firstrun.branches" pref is set to "join-privacy" in the "about:config" page. Also, I have verified that the card respects the specifications from comment 1.
Verified using the latest Firefox Nightly (76.0a1 Build ID - 20200402095145)installed on Windows 10 x64, Mac 10.15.4 and Ubuntu 18.04 x64.