1626069 - Remove JSScript::Create wrapper

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P2)

Description

[Caroline Cullen [:caroline]]

Since hideScriptFromDebugger flag was removed the JSScript::Create wrapper can be removed.

Comment 1

[Caroline Cullen [:caroline]]

Attachment: Bug 1626069 - Remove JSScript::Create wrapper. r?tcampbell

Comment 2

[Ted Campbell [:tcampbell]]

We might as well go further here. Let's try to move JSScript::New to BaseScript and then have BaseScript::CreateRawLazy use the new BaseScript::New so we have a single source of allocation. The places that previously used JSScript::Create can use the BaseScript::New directly, and the places that make lazy scripts can continue using CreateLazy/CreateRawLazy for now.

PRobably will need to fix the argument ordering to be consistent everywhere too.

Comment 3

[Ted Campbell [:tcampbell]]

EDIT: Ignore this comment. I was looking at an old tree... Comment 2 stands.

Actually.. maybe we should leave JSScript::Create as a wrapper around BaseScript::New for now since it also has the immutableFlags argument.

Comment 4

[Caroline Cullen [:caroline]]

Attachment: Bug 1626069 - Move JSScript::New to BaseScript and remove the rest of JSScript::Create. r?tcampbell

Depends on D68882

Comment 5

[Caroline Cullen [:caroline]]

Attachment: Bug 1626069 - Reorder JSScript::Create parameters so they match other call orderings. r?tcampbell

Depends on D69148

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43d1a93d10cb
Remove JSScript::Create wrapper. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/8de231e97e58
Move JSScript::New to BaseScript and remove the rest of JSScript::Create. r=tcampbell
https://hg.mozilla.org/integration/autoland/rev/46cab189d719
Reorder JSScript::Create parameters so they match other call orderings. r=tcampbell

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/43d1a93d10cb
https://hg.mozilla.org/mozilla-central/rev/8de231e97e58
https://hg.mozilla.org/mozilla-central/rev/46cab189d719

Comment 8

[Caroline Cullen [:caroline]]

Because JSScript::Create returns a JSScript we cannot call BaseScript::New directly, It is still necessary to keep JSScript::Create around to do a static cast of the BaseScript.