Closed Bug 1626104 Opened 4 years ago Closed 4 years ago

Make mach lint --config-path relative to topsrcdir

Categories

(Developer Infrastructure :: Lint and Formatting, enhancement)

enhancement
Not set
normal

Tracking

(firefox76 fixed)

RESOLVED FIXED
mozilla76
Tracking Status
firefox76 --- fixed

People

(Reporter: rjl, Assigned: rjl)

Details

Attachments

(1 file)

This is a followup to bug 1622974 which added --config-path to "mach lint".
I realized as I was getting ready to deploy the necessary changes in comm-central, that as implemented, it's a bit difficult to use as the paths are relative to the current directory.

It would be much easier to use if paths passed to --config-path are considered relative to topsrcdir. Then it's trivial to configure an alias in machrc for linting with the comm-central configuration and not have to provide --config-path every time.

Since --config-path is new and as yet unused in comm-central, this is the best opportunity to make the change.

This makes the --config-path option relative to topsrcdir rather then the current
directory.
Using a relative path is difficult for a developer running mach lint locally as
the command has to change as the working directory changes. A stable base path also
facilitates creating an alias in machrc.

Assignee: nobody → rob
Status: NEW → ASSIGNED
Pushed by thunderbird@calypsoblue.org:
https://hg.mozilla.org/integration/autoland/rev/09d891b8ec9b
Change mach lint --config-path to be relative to topsrcdir. r=linter-reviewers,ahal
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: