Avoid extraneous SrcNotes in self-hosted code
Categories
(Core :: JavaScript Engine, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox76 | --- | fixed |
People
(Reporter: tcampbell, Assigned: tcampbell)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
We should avoid generating line/col and debugger info for the self-hosted script. The script is not normally debug-able and doesn't change once shipped.
This saves about 40kB from the bytecode size. As well, it makes special cloning cases like MakeDefaultConstructor not have misleading info.
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 1•4 years ago
|
||
Stop generating line/column and breakpoint SrcNotes for self-hosted code.
They have minimal value since the realm is very restricted and use 40kB of
bytecode space.
Note that self-hosted functions still have initial lineno/column information
and this only concerns the fine-grained locations within a function.
Pushed by tcampbell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ce665bb34e2b Don't generate location notes for self-hosted code. r=jandem
|
||
Comment 3•4 years ago
|
||
| bugherder | ||
|
||
Comment 4•4 years ago
|
||
== Change summary for alert #25537 (as of Fri, 03 Apr 2020 04:17:27 GMT) ==
Improvements:
2% Base Content JS windows7-32-shippable opt 3,003,720.00 -> 2,931,373.33
2% Base Content JS windows7-32-shippable opt 3,003,794.67 -> 2,931,549.33
2% Base Content JS macosx1014-64-shippable opt 3,798,331.33 -> 3,723,620.67
2% Base Content JS linux1804-64-shippable opt 3,796,095.33 -> 3,721,760.00
2% Base Content JS linux1804-64-shippable-qr opt 3,796,247.33 -> 3,721,778.67
2% Base Content JS windows10-64-shippable opt 3,863,050.67 -> 3,791,767.33
2% Base Content JS windows10-64-shippable-qr opt 3,863,223.33 -> 3,791,695.33
For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=25537
Description
•