1626155 - nsLayoutUtils::TransformAncestorPointToFrame passes null for ancestor frame

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Timothy Nikkel (:tnikkel)]

https://searchfox.org/mozilla-central/rev/fa2df28a49883612bd7af4dacd80cdfedcccd2f6/layout/base/nsLayoutUtils.cpp#2977

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1626155. nsLayoutUtils::TransformAncestorPointToFrame passes null for ancestor frame. r=botond

It probably doesn't case any problems because the two callers of the function don't hit the case with the bug.

nsLayoutUtils::TransformRootPointToFrame passes nullptr for the ancester frame.

nsIFrame::GetContentOffsetsFromPoint only calls this function if aFrame is in an svg text subtree, so it takes the other branch.

Looks like this was a simple oversight in this change

https://hg.mozilla.org/mozilla-central/rev/204b51a6c6458a30be158a3d1bdca8e9b4edfd67

where TransformRootPointToFrame was changed to TransformAncestorPointToFrame and it originally passed nullptr (which was correct to the Root version fo the function) but didn't get updated in the change.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3506ad8b3ae2
nsLayoutUtils::TransformAncestorPointToFrame passes null for ancestor frame. r=botond

Comment 3

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/3506ad8b3ae2