Cogwheel for Protection level not vertically centered in div
Categories
(Firefox :: Protections UI, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr68 | --- | unaffected |
firefox74 | --- | unaffected |
firefox75 | --- | wontfix |
firefox76 | --- | verified |
firefox77 | --- | verified |
People
(Reporter: cfogel, Assigned: aarushivij)
Details
(Keywords: good-first-bug, regression)
Attachments
(2 files)
36.38 KB,
image/png
|
Details | |
47 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
Affected versions
- 75.0b11, 76.0a1 (2020-03-30)
Affected platforms
- macOS 10.15, Windows 10, Ubuntu 18.04;
Steps to reproduce
- Launch Firefox, access about:protections
- Hover over the cogwheel for the protections level
Expected result
- elements are properly displayed;
Actual result
- top padding doesn't match bottom padding for the icon;
Regression range
- will check if one and provide confirmation asap;
Additional notes
- attached screenshot with the issue.
Comment 1•5 years ago
|
||
Regression range
- First bad: 2020-02-22
- Last good: 2020-02-21
- Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=acc0c8327c266ac0b0c61eecdba6d625957ecf81&tochange=bd65ac107627408a01cf1faf62e59665ba37cf20
Updated•5 years ago
|
Removing the last 3px
here fixes this for me:
https://searchfox.org/mozilla-central/rev/c2bc259414706ef4be5d13df1344eebb7507a51b/browser/components/protections/content/protections.css#237
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
Hello, Can I take up this issue?
Thanks :)
Aarushi
Comment 4•5 years ago
|
||
(In reply to aarushivij from comment #3)
Hello, Can I take up this issue?
Thanks :)
Aarushi
Hi Aarushi, go for it, and thank you!
Updated•5 years ago
|
Assignee | ||
Comment 5•5 years ago
|
||
Comment 7•5 years ago
|
||
bugherder |
Comment 8•5 years ago
|
||
Comment on attachment 9139386 [details]
Bug 1626195 - Cogwheel for Protection level not vertically centered in div r=ewright
Beta/Release Uplift Approval Request
- User impact if declined: Protection Report does not appear polished, since styling of cogwheel is 3 px off center.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): one line CSS only change.
- String changes made/needed: none
Comment 9•5 years ago
|
||
Comment on attachment 9139386 [details]
Bug 1626195 - Cogwheel for Protection level not vertically centered in div r=ewright
Trivial one-liner CSS fix for a visual glitch. Approved for 76.0b5.
Comment 10•5 years ago
|
||
bugherder uplift |
Reporter | ||
Comment 11•5 years ago
|
||
Awesome. Verified with 76.0b5, 77.0a1 (2020-04-15) on the mentioned platforms.
Description
•