Closed Bug 1626215 Opened 5 years ago Closed 4 years ago

Lockwise app focus ring for GooglePlay differs from AppStore

Categories

(Firefox :: about:logins, defect, P3)

defect

Tracking

()

VERIFIED FIXED
Firefox 79
Tracking Status
firefox75 --- wontfix
firefox76 --- wontfix
firefox79 --- verified

People

(Reporter: cfogel, Assigned: kenrick95)

References

Details

(Keywords: polish)

Attachments

(2 files)

Affected versions

  • 75.0b11, 76.0a1 (2020-03-30)

Affected platforms

  • macOS 10.15, Windows 10, Ubuntu 18.04;

Steps to reproduce

  1. Launch Firefox, login with a valid account for sync, access about:logins
  2. Edit any user/login;
  3. Press the tab key until you reach the bottom buttons for redirecting on the Google/Apple stores;

Expected result

  • button decorators are of the same format;

Actual result

  • for GooglePlay the wrong div seems to be selected/active;

Regression range

  • will check and provide one asap;

Additional notes

  • attached recording with the issue.
Has Regression Range: --- → no
Has STR: --- → yes
See Also: → 1626220

Not a regression, updating information in initial comment as well.

Has Regression Range: no → ---
Keywords: polish
Priority: -- → P3
Summary: about:logins - tab_selector for GooglePlay differs from AppleStore → Lockwise app focus ring for GooglePlay differs from AppStore

I guess this is caused by the Google Play assets being a larger image with some transparent padding in the image itself. I think this bug would be solved if we could crop those transparent padding out from the Google Play assets

Cropping the images may make it annoying to add more locales in the future as there is a copy of the image per-locale. Could we instead add padding to the iOS one to make it match the Google Play one?

Hmm true. Sure thing let me try that and send a patch soon. Thanks for you suggestion 😄

Another way to fix is to crop the transparent area out of the Google Play assets, but it would be annoying when new locales are added

Assignee: nobody → kenrick95
Status: NEW → ASSIGNED
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/8e198aa18680 Enlarge focus ring area of Apple AppStore to have same height with Google Play's r=MattN
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79

Verified with 79.0a1 (2020-06-15) on macOS 10.15.5, Windows 10, Ubuntu 18.

Status: RESOLVED → VERIFIED
Regressions: 1651727
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: