Closed Bug 1626225 Opened 6 years ago Closed 6 years ago

ASRouterUtils.blockBundle is not a function

Categories

(Firefox :: Messaging System, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 77
Iteration:
76.2 - Mar 23 - Apr 5
Tracking Status
firefox75 --- unaffected
firefox76 --- wontfix
firefox77 --- verified

People

(Reporter: andreio, Assigned: emcminn)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

I hit this error when trying to block TRAILHEAD_CARD_11, probably because of the "bundled": 3, attribute on the message.
Maybe we can also add some unit tests around this functionality to catch regressions.

Yes, I'm seeing it on all the messages that have bundled: 3 instead of the includeBundle object - could be this is either an issue with the template, or with the function. I'll take a look at both and pinpoint what's happening, and then we can decide how we want to fix it.

Depends on: 1626673
Attachment #9137502 - Attachment description: Bug 1626225 - Restored "blockBundle" function → Bug 1626225 - Restored "blockBundle" function, updated devTools "handleBlock"
Pushed by emcminn@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1d32e44b5a25 Restored "blockBundle" function, updated devTools "handleBlock" r=Mardak,pdahiya
Iteration: --- → 76.2 - Mar 23 - Apr 5
Priority: -- → P1
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 77

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (77.0a1 Build ID - 20200407214402) installed, on Windows 10 x64, Ubuntu 18.04 x64 and Mac 10.15.3. Now, the “TRAILHEAD_CARD_11” is successfully blocked after the “Block” button is clicked and the “ASRouterUtils.blockBundle is not a function” error is no longer displayed in the “Browser Console”.

Status: RESOLVED → VERIFIED

The patch landed in nightly and beta is affected.
:emcminn, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(emcminn)
Flags: needinfo?(emcminn)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: