1626311 - alerticon-error.svg must be replaced following bug 1525178

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Magnus Melin [:mkmelin]]

In bug 1525178 chrome://mozapps/skin/extensions/alerticon-error.svg was removed.
https://hg.mozilla.org/mozilla-central/rev/c10f9b14236f316cf831b7a33f3989bb7183d012

This is now causing
TEST-UNEXPECTED-FAIL | comm/mail/test/static/browser_parsable_css.js | missing chrome://mozapps/skin/extensions/alerticon-error.svg referenced from chrome://messenger/skin/folderPane.css

I guess we'll just have to grab that one and move it to Thunderbird.

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1626311_alerticon-error.patch

Same icon, different location.

Comment 2

[Richard Marti (:Paenglab)]

Comment on attachment 9137173 [details] [diff] [review]
bug1626311_alerticon-error.patch

This looks as it's working. What do you think about using this instead:

  list-style-image: url("chrome://global/skin/icons/warning.svg");
  -moz-image-region: rect(0 16px 16px 0);
  fill: #e62117;

This needs no new icon .

Comment 3

[Magnus Melin [:mkmelin]]

Up to you. I can use that if you like.

Comment 4

[Richard Marti (:Paenglab)]

I prefer my proposal because we need no new icon.

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: bug1626311_alerticon-error.patch

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 9137177 [details] [diff] [review]
bug1626311_alerticon-error.patch

Thanks.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5d9ed9e6028b
replace references to alerticon-error.svg with warning.svg following bug 1525178. r=Paenglab

Comment 8

[Intermittent Failures Robot]

5 failures in 5015 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• comm-central: 5

Platform breakdown:

• linux32-shippable: 1
• windows10-64-shippable: 1
• windows7-32-shippable: 1
• macosx1014-64-shippable: 1
• linux64-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1626311&startday=2020-03-30&endday=2020-04-05&tree=all