Closed Bug 1626311 Opened 4 months ago Closed 4 months ago

alerticon-error.svg must be replaced following bug 1525178

Categories

(Thunderbird :: Theme, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 76.0

People

(Reporter: mkmelin, Assigned: mkmelin)

Details

Attachments

(1 file, 1 obsolete file)

In bug 1525178 chrome://mozapps/skin/extensions/alerticon-error.svg was removed.
https://hg.mozilla.org/mozilla-central/rev/c10f9b14236f316cf831b7a33f3989bb7183d012

This is now causing
TEST-UNEXPECTED-FAIL | comm/mail/test/static/browser_parsable_css.js | missing chrome://mozapps/skin/extensions/alerticon-error.svg referenced from chrome://messenger/skin/folderPane.css

I guess we'll just have to grab that one and move it to Thunderbird.

Attached patch bug1626311_alerticon-error.patch (obsolete) — Splinter Review

Same icon, different location.

Attachment #9137173 - Flags: review?(richard.marti)
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird 76.0
Comment on attachment 9137173 [details] [diff] [review]
bug1626311_alerticon-error.patch

This looks as it's working. What do you think about using this instead:

  list-style-image: url("chrome://global/skin/icons/warning.svg");
  -moz-image-region: rect(0 16px 16px 0);
  fill: #e62117;

This needs no new icon .

Up to you. I can use that if you like.

I prefer my proposal because we need no new icon.

Summary: alerticon-error.svg must be replaced following 1525178 → alerticon-error.svg must be replaced following bug 1525178
Attachment #9137173 - Attachment is obsolete: true
Attachment #9137173 - Flags: review?(richard.marti)
Attachment #9137177 - Flags: review?(richard.marti)
Comment on attachment 9137177 [details] [diff] [review]
bug1626311_alerticon-error.patch

Thanks.
Attachment #9137177 - Flags: review?(richard.marti) → review+

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/5d9ed9e6028b
replace references to alerticon-error.svg with warning.svg following bug 1525178. r=Paenglab

Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.