Open Bug 1626331 Opened 4 years ago Updated 2 years ago

Consider pulling xpcom module version and weave sync version from milestone.txt (or other intree version)

Categories

(Firefox Build System :: General, enhancement, P3)

enhancement

Tracking

(Not tracked)

People

(Reporter: tomprince, Unassigned)

References

Details

Attachments

(2 files)

We currently have code to special case bumping them on merge day, and it does not appear that they ever change otherwise. It would be nice if we could remove that code and just pull the version from elsewhere in-tree.

Bug 1384936 has some context for the weave constant.

Priority: -- → P3

From matrix:

<glandium> I'd say split the bug in two. One for xpcom and one for weave. In the case of xpcom we can actually remove that thing entirely, it's useless now. For weave, I don't know, ni standard8

I'm not aware of WEAVE_VERSION being useful...ever (But maybe Mark is? 😁) It shows up in the Sync logs, and gets sent in the custom User-Agent header and a query param for Sync's network requests, but the Firefox version number is what we look at first. I'm not sure we even need the build ID, but, if we want that, we can include it specifically.

(In reply to Lina Cambridge [:lina] from comment #2)

I'm not aware of WEAVE_VERSION being useful...ever (But maybe Mark is? 😁)

Me either. I suspect it dates from when Sync was an addon. +1 for killing that entirely and as Lina implies, leave it to the sync code to specifically add extra information to the logs if it becomes necessary (which I doubt ever will in practice)

Assignee: nobody → mozilla
Status: NEW → ASSIGNED

The bug assignee didn't login in Bugzilla in the last 7 months.
:mhentges, could you have a look please?
For more information, please visit auto_nag documentation.

Assignee: mozilla → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(mhentges)
Flags: needinfo?(mhentges)
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: