Closed
Bug 1626378
Opened 5 years ago
Closed 5 years ago
Category tabs do not get role="tab"
Categories
(Toolkit :: Add-ons Manager, defect, P1)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
mozilla76
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox74 | --- | unaffected |
| firefox75 | --- | unaffected |
| firefox76 | + | fixed |
People
(Reporter: Jamie, Assigned: mstriemer)
References
(Regression)
Details
(Keywords: access, regression, Whiteboard: [access-p1])
Attachments
(1 file)
In the new HTMl side bar, the category buttons are missing role="tab". They do get a parent role="tablist" and they do get aria-selected="true" when selected. Unfortunately, aria-selected is currently ignored because the role is wrong.
The tabs for individual add-ons still get role="tab" as they should.
|
Assignee | |
Comment 1•5 years ago
|
||
Hmm, I could've swore they had one, although I do remember refactoring that at one point and may have forgotten about these buttons. I'll add that back in.
Assignee: nobody → mstriemer
Priority: -- → P1
|
|
Assignee | |
Comment 2•5 years ago
|
||
Pushed by mstriemer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3d2fd118323b
Set role="tab" on about:addons categories r=rpl
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox76:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla76
|
||
Updated•5 years ago
|
Keywords: regression
|
||
Updated•5 years ago
|
status-firefox74:
--- → unaffected
status-firefox75:
--- → unaffected
status-firefox-esr68:
--- → unaffected
|
|
||
Updated•5 years ago
|
tracking-firefox76:
--- → +
|
||
Updated•5 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•