add ftp to permitted protocol handlers
Categories
(WebExtensions :: General, enhancement, P3)
Tracking
(Not tracked)
People
(Reporter: mixedpuppy, Unassigned, Mentored)
Details
(Keywords: good-first-bug)
Once ftp is removed, we could add it to the protocol handlers. This could potentially allow an addon to mitigate the loss of native ftp support.
|
Reporter | |
Comment 1•4 years ago
|
||
Philipp, what do you think about this?
We're thinking of adding ftp to this now, but ignoring it until a version of firefox that has removed the ability to turn on ftp.
|
||
Comment 2•4 years ago
|
||
Redirecting product question in comment 1 from Philipp to Jorge.
|
|
||
Comment 4•4 years ago
|
||
Marking this as a good-first-bug. To get started, see https://wiki.mozilla.org/WebExtensions/Contribution_Onramp
As a first step, we should support protocol_handlers in the schema: https://searchfox.org/mozilla-central/rev/9c72508fcf2bba709a5b5b9eae9da35e0c707baa/toolkit/components/extensions/schemas/extension_protocol_handlers.json#14-23
If the network.ftp.enabled pref is false, then the implementation should allow extensions to register the extension. Otherwise the protocol should be ignored. The implementation of the protocol_handlers API is at https://searchfox.org/mozilla-central/source/toolkit/components/extensions/parent/ext-protocolHandlers.js
The patch should also include a unit test to verify that the change works as expected. Search for protocol_handlers in Searchfox to find existing examples.
|
|
||
Comment 6•4 years ago
|
||
(In reply to xu from comment #5)
Hello, can I work this issue for my Outreachy application?
Yes. We have already chatted on Matrix. The bug will automatically be assigned to you once you attach a patch.
|
|
Reporter | |
Comment 7•3 years ago
|
||
Sorry, given that we needed this right now I took it.
Description
•