1626426 - [about:addons] Page is white while loading in dark mode

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Mark Striemer [:mstriemer]]

Attachment: about-addons white in dark mode.mp4

STR

1. Enable dark mode
   • In OS settings or ui.systemUsesDarkTheme=1
2. Load about:addons

Expected results: Page background is always dark
Actual results: Page background flashes to white then goes dark

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 1626426 - Always have a dark about:addons page in dark mode r?Gijs

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe77998cc746
Always have a dark about:addons page in dark mode r=Gijs

Comment 3

[Razvan Maries]

Backed out for perma failures.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=linux%2C18.04%2Cx64%2Cdebug%2Cmochitests%2Cwith%2Cfission%2Cenabled%2Ctest-linux1804-64%2Fdebug-mochitest-browser-chrome-fis-e10s-11%2Cm-fis%28bc11%29&revision=fe77998cc746e83e51b94292400058c8988a28ff&selectedJob=295966341

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=295966341&repo=autoland&lineNumber=18576

Backout: https://hg.mozilla.org/integration/autoland/rev/f6ce8518fbf3afea29b9e3fd21998e91538d9ef7

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09fc2941dd68
Always have a dark about:addons page in dark mode r=Gijs

Comment 5

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/09fc2941dd68

Comment 6

[Alex Cornestean]

Hello,

Verified the fix using the latest Nightly (77.0a120200409131623) and Beta (76.0b3/20200409223136) under Windows 10 Pro 64-bit and Ubuntu 16.04 LTS. I also managed to reproduce the issue on Nightly 76.0a1/20200331225823.

Refreshing the about:addons page no longer causes the background to flash to white.

Also checked for possible regressions, however, did not find any.