162648 - Form in TABLE/TR does not submit

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Brian Ryner (not reading)]

Using a current trunk build from CVS on Windows 2000:

1. Visit http://m-w.com/
2. Type a work in the dictionary textfield
3. Click "Look it up"

Result: nothing happens
Expected result: form should submit

I think this regressed sometime fairly recently, but I'm not sure exactly when.

Comment 1

[Brian Ryner (not reading)]

Works fine in Mozilla 1.1 beta (2002072204)... we need some more testing to
figure out exactly when this regressed.

Comment 2

[Sam J. Fleet]

Work fine on Moz BuildID# 2002-08-13-04.  What's your build id when the form
submission failed?

Comment 3

[Olav Vitters]

Another form that doesn't submit in 2002-08-14-08 Linux:
  http://gathering.tweakers.net/forum/login

Works in 1.1b.

Comment 4

[Olav Vitters]

Both forms regressed on Linux between the nightly trunk builds
2002-08-13-08-trunk (worked) and 2002-08-14-04-trunk (failed).

Comment 5

[Jerry]

Verified.
Works with 0813 build on win2K, but fail with 0814 build.

Comment 6

[Jerry]

more seriously,
when view source for that url,
 0814 build mozilla will hang.

change severity to critical.

I check the cvs checkin log, may fix of 162502 cause this regression.
add bz to cc list

Comment 7

[John Keiser (jkeiser)]

Attachment: Minimized Testcase

This is a problem of <table><tr><form><td><input></td></form></tr></table>. 
Much more likely a regression of 159359, though form.elements and the input's
.form are both set correctly!

Works on the 10th, doesn't work as of today / yesterday.

Comment 8

[John Keiser (jkeiser)]

The regression is that forms in TABLE/TR no longer have a frame.  The root
problem is that nsPresShell::HandleEventWithTarget inexplicably doesn't send an
event if there is no frame.

Comment 9

[Jerry Baker]

*** Bug 162722 has been marked as a duplicate of this bug. ***

Comment 10

[Olav Vitters]

*** Bug 162830 has been marked as a duplicate of this bug. ***

Comment 11

[Olav Vitters]

*** Bug 162834 has been marked as a duplicate of this bug. ***

Comment 12

[Olav Vitters]

*** Bug 162835 has been marked as a duplicate of this bug. ***

Comment 13

[Matthias Versen [:Matti]]

*** Bug 162881 has been marked as a duplicate of this bug. ***

Comment 14

[Jerry Baker]

Shouldn't this be a blocker? It prevents logon to Yahoo!, AOL, and Slashdot; it
prevents the use of sites like weather.com, m-w.com, etc.; and you can't even
use the search function right at the top of netscape.com.

Comment 15

[Phil Anderton]

Also seems to prevent bugzilla login - this is too ridiculous - changing
severity to blocker.

Comment 16

[Bob Lockie]

I tested a bunch of Win98 builds on "http://www.mail.com/" which I think is the
same problem.
I do not know what -1.0, -1.1, and -trunk builds are but I assumed they are
branches and I chose only -trunk builds.
The problem first appears in the 2002-08-14-09-trunk build.


http://ftp34.newaol.com/pub/mozilla/nightly/2002-08-09-08-trunk/mozilla-win32-installer-sea.exe
works

http://ftp34.newaol.com/pub/mozilla/nightly/2002-08-09-17-trunk/mozilla-win32-installer-sea.exe
MOZILLA caused an invalid page fault in
module <unknown> at 0000:4a56f367.

http://ftp34.newaol.com/pub/mozilla/nightly/2002-08-09-18-trunk/mozilla-win32-installer-sea.exe
works

http://ftp34.newaol.com/pub/mozilla/nightly/2002-08-13-04-trunk/mozilla-win32-installer-sea.exe
works

http://ftp34.newaol.com/pub/mozilla/nightly/2002-08-14-09-trunk/mozilla-win32-installer-sea.exe
fails

Comment 17

[cartman]

http://linuxnewbie.org/forum/usercp.php?s=e3c40190e4d859c599e8074a9ee2bfec login
button doesnt wprk too using Mozilla 2002081600 on Linux

Comment 18

[joki (gone)]

nsPresShell::HandleEventWithTarget handles both content and frame event
dispatch.  The lack of dispatch is due to a null check which has always been
valid before.  The code could be rewritten to handle content which has no frame
but the null check is currently protecting code which assumes the frame is there.

The easier patch will likely be to use nsPresShell::HandleDOMEventWithTarget
which dispatches to content only.  I'm pulling a new tree now to check this out in.

Comment 19

[Asa Dotzler [:asa]]

If this indeed blocks login to bugzilla then it is a smoketest blocker.

Comment 20

[joki (gone)]

Attachment: Proposed patch

Okay, I have a patch which fixes this.	I tested most of the dupes and it works
fine.  Someone mentioned a problem with bugzilla login and I have not had a
problem with that with or without the patch.  If that's real then its something
else.

Comment 21

[Johnny Stenback (:jst)]

Comment on attachment 95478 [details] [diff] [review]
Proposed patch

sr=jst

Comment 22

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 95478 [details] [diff] [review]
Proposed patch

r=bzbarsky

Comment 23

[joki (gone)]

Fixed on trunk.

Comment 24

[Olav Vitters]

*** Bug 163016 has been marked as a duplicate of this bug. ***

Comment 25

[Roscoe Primrose]

Is this fixed on 2002081508 (which still seems to be the most recent one I can
get).  If so, then there's another similar bug when trying to bid on items on
ebay...

Comment 26

[Malcolm Rowe]

*** Bug 163055 has been marked as a duplicate of this bug. ***

Comment 27

[Boris Zbarsky [:bzbarsky]]

The fixed comment is from "2002-08-15 16:43"

This is about 8 hours after "2002081508" (which is "2002-08-15 08:00" or so).

Comment 28

[R.K.Aa.]

*** Bug 163149 has been marked as a duplicate of this bug. ***

Comment 29

[R.K.Aa.]

*** Bug 163209 has been marked as a duplicate of this bug. ***

Comment 30

[Matthias Versen [:Matti]]

*** Bug 163296 has been marked as a duplicate of this bug. ***

Comment 31

[Wesha]

*** Bug 163347 has been marked as a duplicate of this bug. ***

Comment 32

[Vladimir Ermakov]

verifying on build 2002-08-23-08-trunk

Comment 33

[Benjamin Smedberg]

*** Bug 148806 has been marked as a duplicate of this bug. ***