1626517 - Use mozilla::Ignore in mozilla::Decoder calls is appropriate

Status: RESOLVED FIXED

(Core :: Internationalization, task, P3)

Description

[Henri Sivonen (:hsivonen)]

Bug 1345842 added mozilla::Ignore. Review usage of mozilla::Decoder (and mozilla::Encoder) for cases where one of the return tuple elements is given a name and then passed into mozilla::Unused and replace those cases with mozilla::Ignore.

Comment 1

[Shazib Summar [:ssummar]]

Attachment: Bug 1626517 - Replaced mozilla::Unused with mozilla::Ignore in mozilla::Decoder/mozilla::Encoder calls. r=m_kato

Comment 2

[Shazib Summar [:ssummar]]

Hi there, I added a patch. Let me know if there needs to be any revisions.

Comment 3

[Shazib Summar [:ssummar]]

Btw doesn't his bug block bug 1603127 as structured bindings don't support selecting specified variables like Tie does through mozilla::Ignore

Comment 4

[Makoto Kato [:m_kato]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ccadb13f8ddc6c36a22a49cf82d2c7ea159c6a52

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8860e1ebb78
Replaced mozilla::Unused with mozilla::Ignore in mozilla::Decoder/mozilla::Encoder calls. r=m_kato

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a8860e1ebb78

Comment 7

[Henri Sivonen (:hsivonen)]

Thanks!

Comment 8

[Shazib Summar [:ssummar]]

(In reply to Henri Sivonen (:hsivonen) from comment #7)

Thanks!

Anytime.