1626583 - Perma toolkit/components/remotebrowserutils/tests/browser/browser_httpToFileHistory.js | Test timed out - when Gecko 76 merges to Beta on 2020-04-06

Status: VERIFIED FIXED

(Core :: DOM: Navigation, defect, P1)

Description

[Narcis Beleuzu [:NarcisB]]

[Tracking Requested - why for this release]:

Central as Beta simulation:
https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=295728151&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=a8530183bf8b0986eed56b2881944b7589bc9028
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=295728151&repo=try&lineNumber=4664

Log snippet:
[task 2020-04-01T10:55:22.339Z] 10:55:22 INFO - TEST-PASS | toolkit/components/remotebrowserutils/tests/browser/browser_httpToFileHistory.js | Initial Navigation URL Scheme - "https" == "https" -
[task 2020-04-01T10:55:22.339Z] 10:55:22 INFO - Buffered messages finished
[task 2020-04-01T10:55:22.339Z] 10:55:22 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/remotebrowserutils/tests/browser/browser_httpToFileHistory.js | Test timed out -
[task 2020-04-01T10:55:22.340Z] 10:55:22 INFO - GECKO(5111) | MEMORY STAT | vsize 20975151MB | residentFast 1087MB
[task 2020-04-01T10:55:22.341Z] 10:55:22 INFO - TEST-OK | toolkit/components/remotebrowserutils/tests/browser/browser_httpToFileHistory.js | took 90029ms
[task 2020-04-01T10:55:22.341Z] 10:55:22 INFO - Not taking screenshot here: see the one that was previously logged
[task 2020-04-01T10:55:22.342Z] 10:55:22 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/remotebrowserutils/tests/browser/browser_httpToFileHistory.js | Found a tab after previous test timed out: file:///builds/worker/workspace/build/tests/mochitest/browser/toolkit/components/remotebrowserutils/tests/browser/dummy_page.html -
[task 2020-04-01T10:55:22.342Z] 10:55:22 INFO - checking window state

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Is this caused by the changes in bug 1597154?

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug is a regression, but please revert this change in case of error.

Comment 3

[Paul Bone [:pbone]]

Thanks,

Yes it's very likely that Bug 1597154 caused this but I'll check that also and investigate.

Comment 4

[Paul Bone [:pbone]]

Yep, confirmed that my changes caused the regression.

Comment 5

[Cosmin Sabou [:CosminS]]

Paul, any chance there will be a patch for this before the central to beta merge on monday? Thank you.

Comment 6

[Paul Bone [:pbone]]

Yep, working on it now (It's now Monday in Australia).

Comment 7

[Paul Bone [:pbone]]

Attachment: Bug 1626583 - Always disable allowLinkedWebInFileUriProcess r=nika

allowLinkedWebInFileUriProcess was supposed to work when document channel is
disabled, but it looks like I broke it in Bug 1597154. Rather than fix it,
let's disable it because it's deprecated anyway.

Comment 8

[Intermittent Failures Robot]

5 failures in 5015 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 5

Platform breakdown:

• macosx1014-64-devedition: 1
• windows7-32: 2
• windows10-64-qr: 1
• macosx1014-64: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1626583&startday=2020-03-30&endday=2020-04-05&tree=all

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ce5057ca838
Always disable allowLinkedWebInFileUriProcess r=nika

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Nika, can you request uplift for the patch to beta? RelMan and Sheriffing would like to fix the issue soon on beta. Thank you.

Comment 11

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 9138440 [details]
Bug 1626583 - Always disable allowLinkedWebInFileUriProcess r=nika

Beta/Release Uplift Approval Request

• User impact if declined: http(s): -> file: URI navigations may not load or maintain session history correctly.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change disables a pref which has been off on nightly since Feb. 12, and has been deprecated with DocumentChannel enabled. The configuration of DocumentChannel combined with this pref being enabled was never intended to be supported.
• String changes made/needed: None

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9138440 [details]
Bug 1626583 - Always disable allowLinkedWebInFileUriProcess r=nika

Approved for 76.0b1.

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/d4f88177f5be

Comment 14

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/5ce5057ca838

Comment 15

[Cristina Coroiu [:ccoroiu]]

Verified as fixed with this beta sim:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=58dc222258be33c82ad1b9ac71ec15022375f51f&searchStr=linux%2C18.04%2Cx64%2Casan%2Copt%2Cmochitests%2Ctest-linux1804-64-asan%2Fopt-mochitest-browser-chrome-e10s-9%2Cm%28bc9%29&selectedJob=296579038