1626627 - The "Edit" and "Remove" buttons of a vulnerable/breached login cannot be focused using keyboard navigation

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P1)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: Edit and Remove buttons cannot be focus.gif

[Affected versions]:

• Nightly 76.0a1 (Build ID: 20200329214909)

[Affected Platforms]:

• Windows 10 x64
• Mac 10.14.6
• Ubuntu 18.04 x64

[Prerequisites]:

• Have a profile with at least 3 saved logins in which one is breached and one is vulnerable.

[Steps to reproduce]:

1. Open the Firefox browser with the profile from prerequisites.
2. Select a vulnerable/breached login.
3. Click and hold the "Create New Login" button and release it in order for the button to be focused.
4. Press the "Tab" key a single time.
5. Observe what button is focused on.

[Expected result]:

• The "Edit" button is focused.

[Actual result]:

• The "Go to [website_name]" link is focused.

[Regression]:

• This issue is not reproducible with older Nightly 76.0a1 builds. Using mozregression tools we have found the following pushlog which contain the bug which introduced this behavior:
• Pushlog: link
• From this pushlog I suspect that bug Bug 1625958 introduced this behavior.

[Notes]:

• When the vulnerable/breached login is elected, the "Edit" button is automatically focused and the "Remove" button is focused next if the "Tab" key is pressed. But, the "Edit" and "Remove" button are no longer focused using keyboard navigation.
• The "Edit" and "Remove" buttons can also be focused using keyboard navigation if you click the empty area above the buttons.
• Attached a screen recording with the issue.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1626627 - Change the first tabbed button to the Edit button on the login-item since the alerts moved under the title. r?sfoster,MattN

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3b192a0aa83
Change the first tabbed button to the Edit button on the login-item since the alerts moved under the title. r=MattN

Comment 3

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/e3b192a0aa83

Comment 4

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue and is no longer reproducible using the latest Nightly 76.0a1 (Build ID: 20200405212522) on Windows 10 x64, Mac 10.14, Ubuntu 18.04 x64.

• The "Edit" and "Remove" buttons of a vulnerable/breached login can be focused using keyboard navigation.