Closed Bug 1626665 Opened 4 months ago Closed 4 months ago

Declare some methods around `nsTextFrame` `const` or `static`

Categories

(Core :: Layout, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: mbrodesser, Assigned: mbrodesser)

Details

Attachments

(12 files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review

Simplifies reasoning about them.

Pushed by mbrodesser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5d21b0d02317
declare some methods around `nsTextFrame` `const` or `static`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/68cac1ea2e56
part 2) Declare some methods in `ClusterIterator` `const`. r=hsivonen
Keywords: leave-open

nsPeekOffsetStruct contains a mixture or input and output members.
This simplifies reasoning about them.

Depends on D69573

Pushed by mbrodesser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9b72e1a129c2
part 3) Declare more methods around `nsTextFrame` `const`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/a1a887ddf61b
part 4) Reorder code in `nsFrameSelection::MoveCaret` to allow `nsPeekOffsetStruct::mDirection` to become `const`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/ef295432e72c
part 5) Declare remaining input-only members of `nsPeekOffsetStruct` `const`. r=hsivonen
Pushed by mbrodesser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d2979371ace0
part 6) Move documentation of `nsIFrame::PeekOffsetWord` and remove outdated part of it. r=hsivonen
Pushed by mbrodesser@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c3077f237e2c
part 7) Declare `nsILineIterator::GetLine` `const`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/a9c78e573e94
part 8) Declare `nsLineIterator::GetNextSiblingOnLine` `const`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/aafddd466e0a
part 9) Declare more methods around `nsTable*` `const`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/3916739e5a13
part 10) Declare `nsILineIterator::FindFrameAt` `const`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/bfaf92cfdba8
part 11) Declare `nsILineIterator::GetNumLines` `const`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/f39a87ff23d8
part 12) Use `const` line-iterator in `nsFrame::GetNextPrevLineFromeBlockFrame`. r=hsivonen
Keywords: leave-open
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.