1626665 - Declare some methods around `nsTextFrame` `const` or `static`

Status: RESOLVED FIXED

(Core :: Layout, enhancement)

Description

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Simplifies reasoning about them.

Comment 1

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1626665: declare some methods around `nsTextFrame` `const` or `static`. r=hsivonen

Comment 2

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1626665: part 2) Declare some methods in `ClusterIterator` `const`. r=hsivonen

Depends on D69225

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d21b0d02317
declare some methods around `nsTextFrame` `const` or `static`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/68cac1ea2e56
part 2) Declare some methods in `ClusterIterator` `const`. r=hsivonen

Comment 4

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1626665: part 3) Declare more methods around `nsTextFrame` `const`. r=hsivonen

Comment 5

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/5d21b0d02317
https://hg.mozilla.org/mozilla-central/rev/68cac1ea2e56

Comment 6

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1626665: part 4) Reorder code in `nsFrameSelection::MoveCaret` to allow `nsPeekOffsetStruct::mDirection` to become `const`. r=hsivonen

nsPeekOffsetStruct contains a mixture or input and output members.
This simplifies reasoning about them.

Depends on D69573

Comment 7

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1626665: part 5) Declare remaining input-only members of `nsPeekOffsetStruct` `const`. r=hsivonen

Depends on D69769

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b72e1a129c2
part 3) Declare more methods around `nsTextFrame` `const`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/a1a887ddf61b
part 4) Reorder code in `nsFrameSelection::MoveCaret` to allow `nsPeekOffsetStruct::mDirection` to become `const`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/ef295432e72c
part 5) Declare remaining input-only members of `nsPeekOffsetStruct` `const`. r=hsivonen

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/9b72e1a129c2
https://hg.mozilla.org/mozilla-central/rev/a1a887ddf61b
https://hg.mozilla.org/mozilla-central/rev/ef295432e72c

Comment 10

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1626665: part 6) Move documentation of `nsIFrame::PeekOffsetWord` and remove outdated part of it. r=hsivonen

Otherwise it's easy to overlook.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2979371ace0
part 6) Move documentation of `nsIFrame::PeekOffsetWord` and remove outdated part of it. r=hsivonen

Comment 12

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1626665: part 7) Declare `nsILineIterator::GetLine` `const`. r=hsivonen

Comment 13

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1626665: part 8) Declare `nsLineIterator::GetNextSiblingOnLine` `const`. r=hsivonen

Depends on D70012

Comment 14

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1626665: part 9) Declare more methods around `nsTable*` `const`. r=hsivonen

Depends on D70013

Comment 15

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1626665: part 10) Declare `nsILineIterator::FindFrameAt` `const`. r=hsivonen

Depends on D70014

Comment 16

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1626665: part 11) Declare `nsILineIterator::GetNumLines` `const`. r=hsivonen

Depends on D70015

Comment 17

[Mirko Brodesser (:mbrodesser) -- not reading bugmails currently]

Attachment: Bug 1626665: part 12) Use `const` line-iterator in `nsFrame::GetNextPrevLineFromeBlockFrame`. r=hsivonen

Depends on D70016

Comment 18

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/d2979371ace0

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3077f237e2c
part 7) Declare `nsILineIterator::GetLine` `const`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/a9c78e573e94
part 8) Declare `nsLineIterator::GetNextSiblingOnLine` `const`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/aafddd466e0a
part 9) Declare more methods around `nsTable*` `const`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/3916739e5a13
part 10) Declare `nsILineIterator::FindFrameAt` `const`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/bfaf92cfdba8
part 11) Declare `nsILineIterator::GetNumLines` `const`. r=hsivonen
https://hg.mozilla.org/integration/autoland/rev/f39a87ff23d8
part 12) Use `const` line-iterator in `nsFrame::GetNextPrevLineFromeBlockFrame`. r=hsivonen

Comment 20

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c3077f237e2c
https://hg.mozilla.org/mozilla-central/rev/a9c78e573e94
https://hg.mozilla.org/mozilla-central/rev/aafddd466e0a
https://hg.mozilla.org/mozilla-central/rev/3916739e5a13
https://hg.mozilla.org/mozilla-central/rev/bfaf92cfdba8
https://hg.mozilla.org/mozilla-central/rev/f39a87ff23d8