16267 - Can't paste copied text into certain applications

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[Roman R.]

Build #: 10/12/99

Steps to reproduce:
1. select a URL in the URL bar and press CTRL+c;
2. paste in another application.

Results:
 In another Mozilla window, MS Word, and Wordpad: pasted fine
 In Notepad, cmd, IE, or Run text field in the Start menu: not pasted at all;
 In NN 4.7, Servant Salamander (a file manager), Ultraedit: pasted fine except
for the last character.

Comment 1

[Eli Goldberg]

Good catch. Confirmed on same build.

Reassigning to Akkana to assign to whoever is doing Win32 clipboard now.

Comment 2

[Kathleen :Brade]

Eli--is Windows the only platform that is having this problem?  What about the
different apps on Macintosh?

Comment 3

[Akkana Peck]

Pinkerton owns the Windows clipboard now.

Comment 4

[Eli Goldberg]

I've seen no evidence that this is a problem on the Macintosh; since the
applications in question don't exist on the Mac (other than NC 4.7, on which it
works), there's no easy way to confirm.

Comment 5

[Peter Trudelle]

Text copied from URL bar using today's opt bits on Win98 now pastes fine in
Notepad, IE, Run, 4.7, Mozilla.  Resolving as worksforme, please reopen if
you're still seeing a problem

Comment 6

[Masatoshi Kimura [:emk]]

This bug does not occurs on Win98, but still occurs on WinNT.
Reopening.

Comment 7

[Masatoshi Kimura [:emk]]

Attachment: proposed patch

Comment 8

[leger]

Clearing WORKSFORME resolution due to reopen of this bug.

Comment 9

[Mike Pinkerton (not reading bugmail)]

i'll look at the patch today. thanks! actually, a quick description of the patch
would be helpful to give me some context, i can't really tell just by looking
quickly at the diff what was broken and what the fix is.

Comment 10

[Masatoshi Kimura [:emk]]

Description of the patch:

1. (nsDataObj.cpp)
   CF_TEXT and CF_UNICODETEXT clipboard formats need a null terminator,
   but it is not added on WinNT (because GlobalAlloc() do not round up
   allocation length on WinNT).
   As a result, the last character is ignored when paste in the NN4.7.

2. (nsXIFFormatConverter.cpp)
   IE and Notepad (on WinNT) request the CF_UNICODETEXT clipboard format,
   but the converter does not support the kUnicodeMime flavor.
   As a result, request for paste fails.

Do you understand? (My English is poor, sorry...)

Comment 11

[Mike Pinkerton (not reading bugmail)]

understood. i'm actually removing the optimization that deals with assuming there
will be rounding. so we waste a few extra bytes on win98. big deal, it makes the
code much easier to follow.

thanks for the summary!

Comment 12

[Mike Pinkerton (not reading bugmail)]

fixes checked in. thanks a lot!

Comment 13

[Eli Goldberg]

*** Bug 17194 has been marked as a duplicate of this bug. ***

Comment 14

[Masatoshi Kimura [:emk]]

Verified fixed using 1999102808 build.