1626725 - [wpt-sync] Sync PR 22621 - [css-grid] Update item placement when grid-template-areas changes

Status: RESOLVED FIXED

(Core :: Layout: Grid, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 22621 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/22621
Details from upstream follow.

Oriol Brufau <[e-mail]> wrote:

[css-grid] Update item placement when grid-template-areas changes

Before r747669, both explicit and implicit named lines were stored in
NamedGridColumnLines and NamedGridRowLines. But that patch moved the
implicit ones into their own ImplicitNamedGridColumnLines and
ImplicitNamedGridRowLines fields.

However, LayoutGrid::NamedGridLinesDefinitionDidChange was not updated
to also look at the new fields. Therefore, a dynamic change in
grid-template-areas might not force the grid items to be placed again.

BUG=1066679

TEST=external/wpt/css/css-grid/placement/grid-placement-using-named-grid-lines-007.html

Change-Id: I4b6ff2de1f1c13f985b146169f39283613defc88
Reviewed-on: https://chromium-review.googlesource.com/2132397
WPT-Export-Revision: 50c87e5b06c92752ac2f16ba7c07aa720b6fa50f

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=aa229b7c03da4ca31b799e700bffdcbc28ea5683

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/927b644c8551
[wpt PR 22621] - [css-grid] Update item placement when grid-template-areas changes, a=testonly

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/927b644c8551