1626754 - ContentBlocking.cpp: do not use 'else' after 'return'

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, task)

Description

[Sylvestre Ledru [:Sylvestre]]

+++ This bug was initially created as a clone of Bug #1626753 +++

Filling as a good first bug to learn workflows.

      return StorageAccessGrantPromise::CreateAndReject(false, __func__);
    } else if (behavior == nsICookieService::
                               BEHAVIOR_REJECT_TRACKER_AND_PARTITION_FOREIGN &&
               !nsContentUtils::IsThirdPartyWindowOrChannel(parentInnerWindow,
                                                            nullptr, nullptr)) {

do not use 'else' after 'return'

https://searchfox.org/mozilla-central/source/toolkit/components/antitracking/ContentBlocking.cpp#292-298

As the change is pretty easy, it is mostly to learn how to contribute to Firefox.

Found by http://clang.llvm.org/extra/clang-tidy/checks/readability-else-after-return.html

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.

Comment 1

[kasung]

Attachment: Bug 1626754 - ContentBlocking.cpp: removed else after return. r?sylvestre

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/36f98e42e659
ContentBlocking.cpp: removed else after return. r=sylvestre

Comment 3

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/36f98e42e659