1626869 - newtab_per_cycle setting is inappropriately transformed into reuseTab flag

Status: RESOLVED FIXED

(Testing :: Raptor, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Since bug 1493648 landed for Firefox 65 there is the new newtab_per_cycle setting available for Raptor tests. It means that for each cycle a new needs to be created, and after the test the tab has to be closed.

Sadly this inappropriately gets converted into reuseTab here:

https://searchfox.org/mozilla-central/rev/7fba7adfcd695343236de0c12e8d384c9b7cd237/testing/raptor/webext/raptor/runner.js#149

It basically means keep the tab open, and do NOT close/create a new tab. As such a check like the following is irritating:

https://searchfox.org/mozilla-central/rev/7fba7adfcd695343236de0c12e8d384c9b7cd237/testing/raptor/webext/raptor/runner.js#444

      if (reuseTab && testTabID != 0) {
        // close previous test tab
        ext.tabs.remove(testTabID);

We have to keep the name as newTabPerCycle internally.

Florin, can one of you please fix that? Thanks.

Comment 1

[Florin Strugariu [:Bebe]]

Attachment: Bug 1626869 - newtab_per_cycle setting is inappropriately transformed into reuseTab flag

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11859d1bafb7
newtab_per_cycle setting is inappropriately transformed into reuseTab flag r=perftest-reviewers,whimboo,sparky

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/11859d1bafb7