RC should be non-copyable and its operator= should be defined only in debug builds
Categories
(Core :: MFBT, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox77 | --- | fixed |
People
(Reporter: sg, Assigned: sg)
Details
Attachments
(1 file)
RC should be non-copyable. It already is non-copyable in the atomic variant, but not in the non-atomic variant. This ensures that RefCounted is also non-copyable.
Also, RC's operator= should be defined only in debug builds. As already described in a code comment, it's only used in debug builds (to assign the dead value), and otherwise no modifications other than incrementing & decrementing should be possible.
|
Assignee | |
Comment 1•4 years ago
|
||
Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/16ee5dd004d3 Make RC non-copyable and declare operator= only in debug builds. r=froydnj
|
||
Comment 3•4 years ago
|
||
Backed out for bustages on ElfLoader.
Backout link: https://hg.mozilla.org/integration/autoland/rev/a5be645883482c3a5cf75515d02e7e8bc64450ba
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=296172206&repo=autoland&lineNumber=5705
|
|
Assignee | |
Comment 4•4 years ago
|
||
(In reply to Narcis Beleuzu [:NarcisB] from comment #3)
Backed out for bustages on ElfLoader.
Backout link: https://hg.mozilla.org/integration/autoland/rev/a5be645883482c3a5cf75515d02e7e8bc64450ba
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=296172206&repo=autoland&lineNumber=5705
Fixed the Android builds, and relanded.
Pushed by sgiesecke@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2e9b2b840f49 Make RC non-copyable and declare operator= only in debug builds. r=froydnj
|
||
Comment 6•4 years ago
|
||
| bugherder | ||
Description
•