1626891 - Style tail suggestions differently

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P2)

Description

[Marco Bonardo [:mak]]

Tail suggestions are slightly different from common ones, we may want to style them differently.

Additionally some search suggestions start with an = to indicate they are result of an operation, others may be results of a conversion (currency or unit of measure). The latter may not currently be available to Firefox as a tail suggestion.

We would like to style these results differently to indicate they are special.

Comment 1

[Marco Bonardo [:mak]]

For tail suggestions in particular (very long ones), it's suggested we show them as

[ what time is it in I                      ]
|                   …Italy                  |
|                   …Illinois               |

Comment 2

[Harry Twyford]

Engineering spoke to UX and we're going to do exactly what Marco suggests in comment 1.

Comment 3

[Harry Twyford]

Bumping the points on this since this matching won't always be as easy as the illustration in comment 1. The screenshot in bug 1636696 shows that words in the tail can change, which will require some new string matching behaviour.

I'm going to approach this by rendering the unseen part of the suggestion and then hiding it. Another approach is to measure the length of the unseen part of the string and then offsetting, but that would require waiting for document flush and we don't want to take that performance hit.

Comment 4

[Harry Twyford]

Some intriguing tail suggestion cases and how Chrome lines them up:

london sights in l
                 london

hobbit holes for sale in o
       hole for sale in oregon

hobbit hes for sle in o
       homes for sale in ontario

hobbit hes for sle in om
       homes for sale in omaugh ontario

hobbit hes for sle in hom
       homes for sale in homes for sale

Comment 5

[Harry Twyford]

Attachment: Bug 1626891 - Style tail suggestions differently. r?mak

Depends on D74739

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b2022e31cd9
Style tail suggestions differently. r=mak

Comment 7

[Razvan Maries]

Backed out for xpcshell perma failures on test_search_suggestions_tail.js.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedTaskRun=aMbe6bcSTsCfnY8rm-O1-g-0&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=windows%2C7%2Cdebug%2Cxpcshell%2Ctests%2Ctest-windows7-32%2Fdebug-xpcshell-e10s-1%2Cx%28x1%29&revision=1b2022e31cd978447af02122db21fe6598f0d168

Failurel log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=302462835&repo=autoland&lineNumber=9190

Backout: https://hg.mozilla.org/integration/autoland/rev/4ca082adb91d5fdd84fe8d361dd064e42d2f4edc

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e47fbd2bd52d
Style tail suggestions differently. r=mak

Comment 9

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/e47fbd2bd52d