1626893 - WarpBuilder: fix remaining jit-tests

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, task, P1)

Description

[Jan de Mooij [:jandem]]

Most of the remaining failures are tests we can easily fix to pass with WarpBuilder, for example debugger tests that now stay in Ion/Warp without bailing out where the Ion backend is optimizing out variables.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1626893 part 1 - Ensure we have a loop phi in optimized-out-03.js jit-test. r?iain!

The test is checking "a" is being optimized out by the JIT. For this to work, it
needs to still be a loop phi after redundant phi elimination. Without WarpBuilder
we bail out and then OSR into the loop resulting in OSR phis, but WarpBuilder
doesn't bailout and OSR.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1626893 part 2 - Fix some jit-tests that rely on variables not being optimized out. r?iain!

Depends on D69335

Comment 3

[Jan de Mooij [:jandem]]

Attachment: Bug 1626893 part 3 - Fix some jit-tests to not rely on specific error messages. r?iain!

Depends on D69337

Comment 4

[Jan de Mooij [:jandem]]

Attachment: Bug 1626893 part 4 - Disable WarpBuilder for bug-1444604-reduced.js. r?iain!

Unfortunately this is failing due to bug 1505387. I looked into fixing that, but
it's not simple.

Comment 5

[Jan de Mooij [:jandem]]

Attachment: Bug 1626893 part 5 - Fix array-push-multiple* jit-tests to not call oomAtAllocation(0). r?iain!

oomAtAllocation throws if the argument is <= 0 so make sure that can't happen by
breaking out of the loop if limit would be set to 0.

Comment 6

[Jan de Mooij [:jandem]]

Attachment: Bug 1626893 part 6 - Tweak Memory-drainAllocationsLog-01.js. r?iain!

This fixes the last test failure. The debugger can collect "allocation metadata"
for allocated objects. This test is checking that the objects in the array have
different allocation sites associated with them.

Ion can fail this test because MNewArray is marked as non-effectful so it doesn't
get its own resume point, resulting in the allocation site matching that of the
object literal before it.

We could fix this by making MNewArray* and similar instructions effectful, but
I'm concerned about the perf impact of changing that just for the unlikely event
the memory profiler is being used. Since this is a pre-existing issue, this tweaks
the test to work around it.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf76864b4063
part 1 - Ensure we have a loop phi in optimized-out-03.js jit-test. r=iain
https://hg.mozilla.org/integration/autoland/rev/b38f05345877
part 2 - Fix some jit-tests that rely on variables not being optimized out. r=iain
https://hg.mozilla.org/integration/autoland/rev/10eb39d10994
part 3 - Fix some jit-tests to not rely on specific error messages. r=iain
https://hg.mozilla.org/integration/autoland/rev/563427cce5fc
part 4 - Disable WarpBuilder for bug-1444604-reduced.js. r=iain
https://hg.mozilla.org/integration/autoland/rev/13fceb3484de
part 5 - Fix array-push-multiple* jit-tests to not call oomAtAllocation(0). r=iain

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/cf76864b4063
https://hg.mozilla.org/mozilla-central/rev/b38f05345877
https://hg.mozilla.org/mozilla-central/rev/10eb39d10994
https://hg.mozilla.org/mozilla-central/rev/563427cce5fc
https://hg.mozilla.org/mozilla-central/rev/13fceb3484de

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3bc77baa519
part 6 - Tweak Memory-drainAllocationsLog-01.js. r=iain

Comment 10

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/a3bc77baa519