1626914 - Make Review Apps Pulse credentials a secret

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Infrastructure, defect)

Description

[Armen [:armenzg]]

In the beginning of the Heroku Review Apps it made sense to create a user/password that was shared and publicly available.

Unfortunately, last night, I saw a lot of alerts of queues that were stuck. We landed some code that should be deleting queues once there are no consumers. So we either had a Review app from a long time ago create lot of queues that did not auto-delete or someone locally was doing development and created unknowingly many queues.

Either way, the new Heroku Review apps allow defining config variables (secrets) at the pipeline level and are given to the Review apps upon creation.

I've reset the treeherder-shared-pulse-user password and created a PULSE_URL config var.

This bug will remove the Pulse user/password from app.json and make the Review apps use PULSE_URL instead.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/6241