1626956 - The OS auth dialog is triggered when trying to create a master password even if the OS authentication prompt is disabled

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P2)

Description

[Cosmin Muntean [:cmuntean], Ecosystem QA]

Attachment: OS auth is still triggered even if the functionality is disabled.gif

[Affected versions]:

• Nightly 76.0a1 (Build ID: 20200402095145)

[Affected Platforms]:

• Windows 10 x64
• Mac 10.14.6

[Prerequisites]:

• Have an OS password set.
• Gave at least one login saved.

[Steps to reproduce]:

1. Open the Firefox browser with the profile from prerequisites.
2. Navigate to "about:config" page and set the "signon.management.page.os-auth.enabled" pref to false.
3. Navigate to "about:preferences#privacy" page and scroll down until the "Logins and Passwords" option.
4. Click the "Use a master password" checkbox.
5. Observe the behavior.

[Expected result]:

• The "Change Master Password" dialog is displayed.

[Actual result]:

• The OS auth dialog is displayed even if the feature is disabled by the pref.

[Notes]:

• The issue is still reproducible after browser restart.
• Attached a screen recording with the issue.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1626956 - Check that OS auth is enabled before prompting during Master Password creation. r?MattN,sfoster

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e570f08779f
Check that OS auth is enabled before prompting during Master Password creation. r=MattN

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/6e570f08779f

Comment 4

[Cosmin Muntean [:cmuntean], Ecosystem QA]

I have verified this issue and is no longer reproducible on the latest Nightly 76.0a1 build (Build ID: 20200403063228). Tested on Windows 10 x64m Windows 8.1 x64, Windows 7 x64, Mac 10.14.6 and Mac 10.13.6.

• The OS auth is no longer triggered when trying to create a master password while the OS authentication prompt is disabled.