1627010 - User can zoom out further than initial zoom

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect, P3)

Description

[Martin Balfanz [:mbalfanz]]

STR:

• set apz.allow_zoom to true
• visit planet.mozilla.org
• zoom out using DesktopZooming

ER: the user should not be able to zoom out beyond the initial zoom level (same as Chrome's behavior)
AR: the user can zoom out further, until the horizontal overflow/scrollbar disappears

This might be an edge case as the site has a (probably unwanted) horizontal overflow. However, as a user this can be very confusing. The only way to reliably get back to the initial zoom level is a hard refresh.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&selectedTaskRun=YQLTxyL5S3CduVDwBrSoyw-0&revision=5267dbe8f5602ab371b8fa52681b4163c1bae2ba

The patch fixes the bug but there's a reftest where the diff is now increased beyond the fuzzy threshold. It's unexpected so I'll investigate.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

The failure actually was expected, because the test in question tries to zoom out to 0.5 which is now being disallowed by my patch. So I disabled the test on desktop. New try push: https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=57ad31480671a04a4f0b0fb3e98a1c3cefb638e5

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1627010 - Disallow user from zooming out past initial zoom on desktop. r?botond

THis should continue allowing users to zoom out in RDM mode, or any time that
we are respecting the meta-viewport tag. It's only when we don't respect the
meta-viewport tag that we disable zooming out past initial zoom.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33629b053c3c
Disallow user from zooming out past initial zoom on desktop. r=botond

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/33629b053c3c