1627086 - Init safe browsing later during startup

Status: NEW

(Toolkit :: Safe Browsing, enhancement, P3)

Description

[Alex Thayer [:alexical] (she/her)]

We read around 7MB from the goog-phish-proto.vlpset file during startup, before about:home has finished loading. It seems like this could be pushed back.

Comment 1

[Florian Quèze [:florian]]

Marking fxperf:p3 for now because I'm not sure we could push this back much (I would guess we need it as close as possible to the first network request), so I'm not sure we could gain much.

I think it's initialized at https://searchfox.org/mozilla-central/rev/4d2a9d5dc8f0e65807ee66e2b04c64596c643b7a/browser/components/BrowserGlue.jsm#2073-2080 and there's a comment there saying it needs to be initialized early-ish.

I could be convinced it's higher priority though, especially if you have an idea of where/when we could initialize this instead.

Comment 2

[Alex Thayer [:alexical] (she/her)]

It would need to happen at the same time as it currently does if we're not just loading about:home. But if we are, it would ideally happen once we know about:home has settled. I believe we know about:home has settled around the time we record this timestamp. It would be a bit awkward including it there, but that's about where in the timeline I think it should go. We should also race against that with a callback in _scheduleArbitrarilyLateIdleTasks in case about:home never settles for some reason.

Comment 3

[Emma Malysz]

Attachment: Bug 1627086, delay initialization of SafeBrowsing when loading about:home