1627110 - Crash in [@ nsMsgIncomingServer::GetDeferredServers]

Status: VERIFIED FIXED

(Thunderbird :: General, defect)

Description

[carodri2]

This bug is for crash report bp-a977a83d-fa6b-44e7-816c-c719c0200402.

Top 10 frames of crashing thread:

0 xul.dll static nsMsgIncomingServer::GetDeferredServers comm/mailnews/base/util/nsMsgIncomingServer.cpp:1994
1 xul.dll nsPop3IncomingServer::GetNewMessages comm/mailnews/local/src/nsPop3IncomingServer.cpp:470
2 xul.dll XPTC__InvokebyIndex 
3  @0x1cf6adf100f 
4 xul.dll truncf 
5 xul.dll truncf 
6 xul.dll static XPCWrappedNative::CallMethod js/xpconnect/src/XPCWrappedNative.cpp:1141
7 xul.dll XPC_WN_CallMethod js/xpconnect/src/XPCWrappedNativeJSOps.cpp:947
8 xul.dll js::InternalCallOrConstruct js/src/vm/Interpreter.cpp:581
9 xul.dll Interpret js/src/vm/Interpreter.cpp:3040

Comment 1

[carodri2]

This started happening since the April 1 2020 update for 76.0a1 64-bit.

Steps to replicate the bug:

1. Click on a POP inbox.
2. Click on the "Get new messages" icon in the toolbar.
3. Program crashes.

Comment 2

[Wayne Mery (:wsmwk)]

Thanks for filing the bug report.

Whatever is causing this, we need to resolve before shipping 76 beta.

Comment 3

[Alice0775 White]

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=7b54036ce7d67afa8361606c720287e5710b4775&tochange=16ca51abc6dda000296c7d7d082b9951ca04fd6d
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9af589864188fc4061a020c45914f54fa9f67b0d&tochange=8ec2329bef743261097e558c6dfb07f6e2cd1d9b

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: [e-mail]

From https://searchfox.org/comm-central/diff/24d388390295016c8c3667b7ce46470d462cae0e/mailnews/base/util/nsMsgIncomingServer.cpp#1992

BTW, can there be nulls in the arrays? I see we check that @ line 2016 and wondering if that's really necessary.

Comment 5

[Ben Campbell]

(In reply to Magnus Melin [:mkmelin] from comment #4)

From https://searchfox.org/comm-central/diff/24d388390295016c8c3667b7ce46470d462cae0e/mailnews/base/util/nsMsgIncomingServer.cpp#1992

BTW, can there be nulls in the arrays? I see we check that @ line 2016 and wondering if that's really necessary.

I don't think so. There have been places that suggest that there could be (like this case), so I left the checks in. But by now I'm 90% sure there are no nulls allowed in those arrays.

Comment 6

[Ben Campbell]

Comment on attachment 9137953 [details] [diff] [review]
[e-mail]">[e-mail]

Review of attachment 9137953 [details] [diff] [review]:
-----------------------------------------------------------------

Doh. I've no idea how I screwed that one up so blatantly!
LGTM :-)

Comment 7

[Wayne Mery (:wsmwk)]

(someone) if the patch lands after today's nightly has built, please trigger a new nightly

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0e46814e8707
Fix crash [@ nsMsgIncomingServer::GetDeferredServers]. r=benc

Comment 9

[Magnus Melin [:mkmelin]]

It will be in today's build, starting in a few minutes.

Comment 10

[carodri2]

Awesome. Thank you for your hard work!

Comment 11

[Wayne Mery (:wsmwk)]

verified - no crashes with today's dailies