1627133 - Convert add-ons manager cog menu into ghost button

Status: NEW

(Toolkit :: Add-ons Manager, enhancement, P3)

Description

[Deleted Account]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:74.0) Gecko/20100101 Firefox/74.0

Steps to reproduce:

Nothing needs to go here.

Actual results:

The add-ons manager cog menu button is not a ghost button.

Expected results:

Convert to a ghost button.

In chrome://mozapps/content/extensions/aboutaddons.html, this:
<button class="more-options-button" action="page-options" aria-haspopup="menu" aria-expanded="false" data-l10n-id="addon-page-options-button"></button>

Should become this:
<button class="more-options-button ghost-button" action="page-options" aria-haspopup="menu" aria-expanded="false" data-l10n-id="addon-page-options-button"></button>

Comment 1

[Alin Ilea, Desktop Test Engineering]

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:74.0) Gecko/20100101 Firefox/74.0

Hi,

I will move this enhancement over to a component so developers can take a look over it. If this is not the correct component please feel free to change it to an appropriate one.

Thanks for the report.

Comment 2

[Deleted Account]

By the way, the "cog menu" is what I call the gear at the top of the page, which shows a menupopup on click with options like Check for Updates.

Comment 3

[Mark Striemer [:mstriemer]]

I'm not sure what dictates whether a button should be a ghost button or not. Aaron, what do you think about this? Should the button have the grey background as it currently does or the transparent one?

Comment 4

[Aaron Benson]

I think the ghost button style is more common in our other UI (see New Tab gear in upper-right, about:logins icon usage). I'd suggest adopting the ghost button style for the gear and the ••• menu on the cards. I'd also like to get Emanuela's opinion here so that I'm not undoing some other considered logic around buttons/icons in the design system.

Comment 5

[Deleted Account]

(In reply to Aaron Benson from comment #4)

I think the ghost button style is more common in our other UI (see New Tab gear in upper-right, about:logins icon usage). I'd suggest adopting the ghost button style for the gear and the ••• menu on the cards. I'd also like to get Emanuela's opinion here so that I'm not undoing some other considered logic around buttons/icons in the design system.

If you'd like to see how it looks, add the "ghost-button" class to the cog menu button (.page-options-menu .more-options-button).

Comment 6

[Aaron Benson]

(In reply to Nicohumor from comment #5)

(In reply to Aaron Benson from comment #4)

I think the ghost button style is more common in our other UI (see New Tab gear in upper-right, about:logins icon usage). I'd suggest adopting the ghost button style for the gear and the ••• menu on the cards. I'd also like to get Emanuela's opinion here so that I'm not undoing some other considered logic around buttons/icons in the design system.

If you'd like to see how it looks, add the "ghost-button" class to the cog menu button (.page-options-menu .more-options-button).

Thanks! Mark sent me a couple screengrabs, too (thank Mark!)

Comment 7

[Deleted Account]

Attachment: Deleted

Comment 8

[emanuela [ux]]

(In reply to Aaron Benson from comment #4)

I think the ghost button style is more common in our other UI (see New Tab gear in upper-right, about:logins icon usage). I'd suggest adopting the ghost button style for the gear and the ••• menu on the cards. I'd also like to get Emanuela's opinion here so that I'm not undoing some other considered logic around buttons/icons in the design system.

Not issue with using a ghost button here!

Comment 9

[Deleted Account]

Attachment: PatchedAboutAddons.html

I just submitted a patch for aboutaddons.html, which adds the ghost button class.

Comment 10

[Deleted Account]

(In reply to Nicohumor from comment #9)

Created attachment 9140853 [details]
PatchedAboutAddons.html

I just submitted a patch for aboutaddons.html, which adds the ghost button class.

Can the patch be reviewed please?

Comment 11

[Mark Striemer [:mstriemer]]

Reviews happen on phabricator, a patch for this would need to make it over there. The documentation on phabricator [1] should be able to help.

[1] https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

Comment 12

[Deleted Account]

(In reply to Mark Striemer [:mstriemer] from comment #11)

Reviews happen on phabricator, a patch for this would need to make it over there. The documentation on phabricator [1] should be able to help.

[1] https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html

I know about phabricator but do not like to use it because of the following reasons:

1. It uses a command line tool to submit patches.
2. It requires 2FA enabled on my Bugzilla account.

Is there another way to submit patches that:

• Does not require 2FA enabled on my account, and
• Allows you to submit patches directly from the page, and does not require you to install a program just to submit patches?

Comment 13

[Deleted Account]

Comment on attachment 9140210 [details]
Deleted

Deleted

Comment 14

[Deleted Account]

Comment on attachment 9140210 [details]
Deleted

Hi there, I need this attachment deleted. It contains some customizations that I do not wish to be public.

Comment 15

[David Lawrence [:dkl]]

The content of attachment 9140210 [details] has been deleted for the following reason:

Attachment deleted at request of author