1627164 - lockwise edit/delete button line break

Status: VERIFIED FIXED

(Firefox :: about:logins, defect, P2)

Description

[Guo Yunhe]

Attachment: Button texts break into lines

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:74.0) Gecko/20100101 Firefox/74.0

Steps to reproduce:

1. Go to about:logins
2. Select a website with very long host name
3. Check the buttons in the heading

Actual results:

Texts in buttons are breaking into lines

Expected results:

Texts in buttons should not break into lines

You can fix it by simply apply:

// login-item.css
.delete-button, .edit-button {
flex: 0 0 auto;
}

Comment 1

[kenrick95]

Attachment: Bug 1627164 - Fix edit/delete buttons in about:logins break into lines

This only happens in specific locales (e.g. Japanese) since in such language, line break could happen in each letters. The fix here is to explicitly specify flex property so that the button couldn't shrink further.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df828f4d4697
Fix edit/delete buttons in about:logins break into lines r=MattN

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/df828f4d4697

Comment 4

[Simona Rosu [:srosu], Ecosystem QA]

I have verified this issue using the latest Firefox Nightly 79.0a1 ja build (Build ID: 20200628212804) on Windows 10 x64, Ubuntu 18.04, Mac 10.14.6.

• The strings from the “Remove” and the “Edit” buttons don't break into lines anymore.