1627175 - Move some utility methods in editor classes which can be static to EditorUtils or HTMLEditUtils

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Currently, a lot of utility methods are in editor classes, but it's difficult to find what you want. So, they should be moved to utility classes if they can be static.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 1: Move `HTMLEditor::IsBlockNode()` into `HTMLEditUtils` r=m_kato!

HTMLEditor::IsBlockNode() is a virtual method derived from
EditorBase::IsBlockNode(). For the performance, EditorBase's one just
return false for text node and <br> element. However, these check cost
is really cheap in these days. Therefore, we can make TextEditor also
use rich API.

This patch moves HTMLEditor::NodeIsBlockStatic() and
HTMLEditor::NodeIsInlineStatic() to HTMLEditUtils, and removes the wrapper
of the fommer, HTMLEditor::IsBlockNode() and WSRunScanner::IsBlockNode().

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 2: Move `EditorBase::IsModifiableNode()`, `EditorBase::IsEditable()`, `EditorBase::IsTextElementOrText()` and `EditorBase::IsPaddingBRElementForEmptyEditor()` to `EditorUtils` r=m_kato!

Due to the include hell, EditorBase.h cannot include EditorUtils.h.
Therefore we need these 3 methods once. Additionally, IsModifiableNode()
is really odd method and looks like that it's used for the following 2 purposes:

1. Simply can be editable.
2. Can be removed from parent.

For the former case, we should sort out it with
EditorUtils::IsEditableContent(), but for now, this patch moves it to
HTMLEditUtils::IsSimplyEditable(). On the other hand, for the latter case,
we obviously has a bug. Therefore, this patch creates
HTMLEditUtils::IsRemovableFromParentNode() and make it check whether the
removing node is also editable.

Unfortunately, EditorUtils::IsEditableContent() needs to take editor type.
But it's most callers are in HTMLEditor and most of remains are in
common methods of EditorBase. I guess we could remove this ugly argument
in the future.

Depends on D70874

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 3: Move `EditorBase::AreNodesSameType()` to `HTMLEditUtils` r=m_kato!

It's only non-HTMLEditor user is EditorBase::JoinNodesDeepWithTransaction(),
but it's called only by HTMLEditor. Therefore, we can move it into
HTMLEditUtils and move EditorBase::JoinNodesDeepWithTransaction() to
HTMLEditor.

Depends on D70875

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 4: Get rid of `EditorBase::IsText()` r=m_kato!

A lot of editor code refers nsINode::IsText() directly so that we don't
need to keep the too simple editor API anymore.

Depends on D70876

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 5: Get rid of `EditorBase::GetChildOffset()` and `EditorBase::GetNodeLocation()` r=m_kato!

Their users should use EditorDOMPoint or something instead.

This patch cleans up EditorBase::DoJoinNodes() too because of their heavy
user. It requires only joined nodes because aParent is used only for
removing aContentToJoin, but we now have nsINode::Remove() which does
not require parent node and never fails.

Depends on D70877

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 6: Move "can contain" utility methods to `HTMLEditUtils` r=m_kato!

Actually, they are used only by HTMLEditor because TextEditor finally
returns true for any cases in TextEditor, but the users are overridden by
HTMLEditor and never used by HTMLEditor. Therefore, we cam move them
into HTMLEditUtils.

Depends on D70878

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 7: Move `EditorBase::IsPaddingBRElementForEmptyLastLine()` to `EditorUtils` r=m_kato!

It's also used in <textarea> so that it should be in EditorUtils rather
than HTMLEditUtils.

Depends on D70879

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 8: Move `EditorBase::IsContainer()` to `HTMLEditUtils` r=m_kato!

It's a virtual method which always returns true if TextEditor. Therefore,
we can move it into HTMLEditUtils and we can make the only caller of
EditorBase check IsTextEditor() instead.

Depends on D70880

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 9: Move `HTMLEditor::GetBlock()` and `HTMLEditor::GetBlockNodeParent()` to `HTMLEditUtils` r=m_kato!

This patch also names the former to GetInclusiveAncestorBlockElement() and
the latter to GetAncestorBlockElement() for consistency with modern DOM
API names.

Depends on D70882

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 10: Move `HTMLEditor::GetEnclosingTable()` to `HTMLEditUtils` r=m_kato!

Depends on D70883

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b1b033a7cc0
part 1: Move `HTMLEditor::IsBlockNode()` into `HTMLEditUtils` r=m_kato

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7deca88757e3
part 2: Move `EditorBase::IsModifiableNode()`, `EditorBase::IsEditable()`, `EditorBase::IsTextElementOrText()` and `EditorBase::IsPaddingBRElementForEmptyEditor()` to `EditorUtils` r=m_kato

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61750ef7b681
part 3: Move `EditorBase::AreNodesSameType()` to `HTMLEditUtils` r=m_kato

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6aa949f6383
part 4: Get rid of `EditorBase::IsText()` r=m_kato

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4727bd1c6049
part 5: Get rid of `EditorBase::GetChildOffset()` and `EditorBase::GetNodeLocation()` r=m_kato

Comment 16

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/3b1b033a7cc0
https://hg.mozilla.org/mozilla-central/rev/7deca88757e3
https://hg.mozilla.org/mozilla-central/rev/61750ef7b681

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/774483b023a6
part 6: Move "can contain" utility methods to `HTMLEditUtils` r=m_kato

Comment 18

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/b6aa949f6383
https://hg.mozilla.org/mozilla-central/rev/4727bd1c6049

Comment 19

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/774483b023a6

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5019308a275
part 7: Move `EditorBase::IsPaddingBRElementForEmptyLastLine()` to `EditorUtils` r=m_kato

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6119e9d5fce8
part 8: Move `EditorBase::IsContainer()` to `HTMLEditUtils` r=m_kato

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7488b281a915
part 9: Move `HTMLEditor::GetBlock()` and `HTMLEditor::GetBlockNodeParent()` to `HTMLEditUtils` r=m_kato

Comment 23

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/b5019308a275
https://hg.mozilla.org/mozilla-central/rev/6119e9d5fce8

Comment 24

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4bba077f98e
part 10: Move `HTMLEditor::GetEnclosingTable()` to `HTMLEditUtils` r=m_kato

Comment 25

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/7488b281a915
https://hg.mozilla.org/mozilla-central/rev/a4bba077f98e

Comment 26

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 11: Create `HTMLEditUtils::GetElementIfOnlyOneSelected()` r=m_kato!

As an alternative of HTMLEditor::GetCellFromRange(), this patch creates more
generic utility method.

Depends on D72296

Comment 27

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 12: Get rid of `HTMLEditor::GetCellFromRange()` r=m_kato!

Even though the method returns only in specific cases, but the result affects
only one caller, HTMLEditor::GetNextSelectedTableCellElement(). Therefore,
we can create new generic utility method,
HTMLEditUtils::GetTableCellElementIfOnlyOneSelected() and get rid of
HTMLEditor::GetCellFromRange().

Note that the warnings in HTMLEditor::GetCellFromRange() is just noise for
any callers. So, this gets rid of the useless spam warnings.

Depends on D72585

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf6d7aa96d2a
part 11: Create `HTMLEditUtils::GetElementIfOnlyOneSelected()` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/cce6adfec7be
part 12: Get rid of `HTMLEditor::GetCellFromRange()` r=m_kato

Comment 29

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/bf6d7aa96d2a
https://hg.mozilla.org/mozilla-central/rev/cce6adfec7be

Comment 30

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 13: Get rid of `EditorBase::CreateRange()` r=m_kato!

It's currently enough simple and there is only one user. So, we can get rid
of it.

Depends on D74203

Comment 31

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 14: Create `HTMLEditUtils::GetLastLeafChild()` instead of `EditorBase::GetRightmostChild()` r=m_kato!

Depends on D74204

Comment 32

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 15: Create `HTMLEditUtils::GetFirstLeafChild()` instead of `EditorBase::GetLeftmostChild()` r=m_kato!

This is used by TextEditor::UndoAsAction() too, so, it might be better to be
in EditorUtils. However, it is completely designed for HTMLEditor and
ideally, UndoAsAction should be overridden by HTMLEditor too and
TextEditor should use faster path because of its content is in anonymous
subtree. But we don't have any merit to do that instead of avoiding virtual
call.

Depends on D74361

Comment 33

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d53b11af737f
part 13: Get rid of `EditorBase::CreateRange()` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/3095b3f0aec2
part 14: Create `HTMLEditUtils::GetLastLeafChild()` instead of `EditorBase::GetRightmostChild()` r=m_kato

Comment 34

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d53b11af737f
https://hg.mozilla.org/mozilla-central/rev/3095b3f0aec2

Comment 35

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/900b2aa0b8cb
part 15: Create `HTMLEditUtils::GetFirstLeafChild()` instead of `EditorBase::GetLeftmostChild()` r=m_kato

Comment 36

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/900b2aa0b8cb

Comment 37

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 16: Move `WSRunScanner::GetNextWSNodeInner()` to `HTMLEditUtils` r=m_kato!

It looks for next leaf content or next block element for finding "end reason
node" of WSRunScanner. Especially for clearing the latter case, this
patch renames it to GetNextLeafContentOrNextBlockElement().

Comment 38

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 17: Move `WSRunScanner::GetPreviousWSNodeInner()` to `HTMLEditUtils` r=m_kato!

Similar to the previous patch, this patch moves it into HTMLEditUtils with
renaming it to GetPreviousLeafContentOrPreviousBlockElement().

Depends on D74804

Comment 39

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 18: Move `WSRunScanner::GetNextWSNode()` and `WSRunScanner::GetPreviousWSNode()` to `HTMLEditUtils` r=m_kato!

They are returning same meaning value as
HTMLEditUtils::GetNextLeafContentOrNextBlockElement() and
HTMLEditUtils::GetPreviousLeafContentOrPreviousBlockElement() so that
they can be renamed to same name to overload them.

Depends on D74805

Comment 40

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d010b23f67df
part 16: Move `WSRunScanner::GetNextWSNodeInner()` to `HTMLEditUtils` r=m_kato

Comment 41

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3dbde556656a
part 17: Move `WSRunScanner::GetPreviousWSNodeInner()` to `HTMLEditUtils` r=m_kato

Comment 42

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d010b23f67df

Comment 43

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dffc3c357cee
part 18: Move `WSRunScanner::GetNextWSNode()` and `WSRunScanner::GetPreviousWSNode()` to `HTMLEditUtils` r=m_kato

Comment 44

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3dbde556656a

Comment 45

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/dffc3c357cee

Comment 46

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 19: Move `EditorBase::IsPreformatted()` to `EditorUtils` r=m_kato!

Depends on D75888

Comment 47

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc4525f247b9
part 19: Move `EditorBase::IsPreformatted()` to `EditorUtils` r=m_kato

Comment 48

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/dc4525f247b9

Comment 49

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 20: Move `HTMLEditor::IsEmptyTextNode()` to `HTMLEditUtils` r=m_kato!

Now, it does not depend on HTMLEditor. So, we can move it into the
HTMLEditUtils.

Depends on D112509

Comment 50

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 21: Move `HTMLEditor::IsInVisibleTextFrames()` to `HTMLEditUtils` r=m_kato!

Depends on D112510

Comment 51

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 22: Get rid of `HTMLEditor::IsEmptyTextNode()` r=m_kato!

It returns true only when it's a text node, but the text is empty.
However, HTMLEditUtils::IsVisibleTextNode() is used in
HTMLEditor::IsEmptyNodeImpl(). So, we replace it with directly using
HTMLEditUtils::IsVisibleTextNode().

Depends on D112511

Comment 52

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 23: Move `HTMLEditor::IsEmptyNode()` into `HTMLEditUtils` with making it take `EnumSet` instead of `bool` arguments r=m_kato!

It's hard to understand each caller of HTMLEditor::IsEmptyNode() tries to
check with multiple bool arguments. Therefore, they should be replaced
with an EnumSet.

Note that only the first argument is reverted the meaning. Therefore, if
it's omitted or false, EmptyCheckOption::TreatSingleBRElementAsVisible
is specified explicitly. Otherwise, i.e., true, nothing should be
specified.

Depends on D112512

Comment 53

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d28de60718cd
part 20: Move `HTMLEditor::IsEmptyTextNode()` to `HTMLEditUtils` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/68551101467a
part 21: Move `HTMLEditor::IsInVisibleTextFrames()` to `HTMLEditUtils` r=m_kato

Comment 54

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d246ff939abd
part 22: Get rid of `HTMLEditor::IsEmptyTextNode()` r=m_kato

Comment 55

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/d28de60718cd
https://hg.mozilla.org/mozilla-central/rev/68551101467a
https://hg.mozilla.org/mozilla-central/rev/d246ff939abd

Comment 56

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/92667a7f0447
part 23: Move `HTMLEditor::IsEmptyNode()` into `HTMLEditUtils` with making it take `EnumSet` instead of `bool` arguments r=m_kato

Comment 57

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/92667a7f0447

Comment 58

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 24: Make `EditorBase::FindNode` and `EditorBase::Get*NodeInternal()` take an `EnumSet` instead of multiple `bool` arguments r=m_kato!

Before moving them from EditorBase, they should take only one option argument
whose type is an EnumSet class.

Note that I wanted to name each option for optional behavior, but
FindAnyDataNode requires to revert the its meaning (I.e., only with this
patch, true should be set an option). Therefore, the following patch renames
it.

Comment 59

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 25: Rename `WalkTreeOption::FindAnyDataNode` to `WalkTreeOption::IgnoreDataNodeExceptText` r=m_kato!

So, the meaning is reverted of this action. But with this change, the scanner
methods scans any nodes by default. This is simpler to understand from the
callers.

Depends on D113228

Comment 60

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 26: Rename `EditorBase::Get*NodeInternal()` to `Get*Content()` r=m_kato!

The following patches will get rid of inline wrapper methods of them.
Therefore, they shouldn't be called as "internal". And they return
nsIContent* instead of nsINode* so, Get*Content() is better name for
them.

Depends on D113229

Comment 61

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 27: Get rid of `EditorBase::GetNextNode()` and `EditorBase::GetPreviousNode()` r=m_kato!

Depends on D113230

Comment 62

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 28: Get rid of `EditorBase::GetNextElementOrText()` and `EditorBase::GetPreviousElementOrText()` r=m_kato!

Depends on D113231

Comment 63

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 29: Get rid of `EditorBase::GetNextElementOrTextInBlock()` and `EditorBase::GetPreviousElementOrTextInBlock()` r=m_kato!

Depends on D113232

Comment 64

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 30: Get rid of `EditorBase::GetNextEditableNodeInBlock()` and `EditorBase::GetPreviousEditableNodeInBlock()` r=m_kato!

Depends on D113233

Comment 65

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 31: Get rid of `EditorBase::GetNextEditableNode()` and `EditorBase::GetPreviousEditableNode()` r=m_kato!

Depends on D113234

Comment 66

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 32: Get rid of `EditorBase::GetNextNodeInBlock()` and `EditorBase::GetPreviousNodeInBlock()` r=m_kato!

Depends on D113235

Comment 67

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 33: Make `EditorBase::FindNode()` and `EditorBase::FindNextLeafNode()` static r=m_kato!

They are instance members of EditorBase only for referring editor type and
editing host. Therefore, we can make them static with making them take
editor type and ancestor limiter as arguments.

Depends on D113236

Comment 68

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 34: Make `EditorBase::GetNextContent()` and `EditorBase::GetPreviousContent()` static r=m_kato!

Depends on D113237

Comment 69

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 35: Move `EditorBase::GetFirstEditableNode()` into `HTMLEditUtils` r=m_kato!

Only the user is EditorBase::BeginningOfDocument() which is used by both
TextEditor and HTMLEditor. However, if it's a TextEditor, expected
result is only the first text node only when there is one. Therefore, we can
move it into HTMLEditUtils and make EditorBase::BeginningOfDocument()
find the text node by it self. Then, we can get rid of using
EditorBase::GetEditorType() in this case.

Depends on D113238

Comment 70

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 36: Make `EditorBase::CreateTransactionForCollapsedRange()` use `EditorBase::GetNextContent()` and `EditorBase::GetPreviousContent()` only when it's an `HTMLEditor` r=m_kato!

If the editor instance is a TextEditor, the root element has to be
anonymous <div> element and it has only one text node when it has non-empty
value. Therefore, if it's in TextEditor, the method does not need to use
the complicated APIs for finding a text node from the anonymous <div> element
or padding <br> element since it can adjust the given point into the text
node without such API.

Depends on D113239

Comment 71

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 37: Get rid of editor type argument from `EditorBase::GetNextContent()` and `EditorBase::GetPreviousContent()` r=m_kato!

Depends on D113240

Comment 72

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 38: Move `EditorBase::GetNextContent()` and `EditorBase::GetPreviousContent()` to `HTMLEditUtils` r=m_kato!

Depends on D113241

Comment 73

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 39: Get rid of `HTMLEditor::GetNextHTMLElementOrTextInBlock()` and `HTMLEditor::GetPreviousHTMLElementOrTextInBlock()` r=m_kato!

Depends on D113242

Comment 74

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 40: Get rid of `HTMLEditor::GetNextHTMLElementOrText()` and `HTMLEditor::GetPreviousHTMLElementOrText()` and their internal methods r=m_kato!

Depends on D113279

Comment 75

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 41: Get rid of `HTMLEditor::GetNextEditableHTMLNodeInBlock()` and `HTMLEditor::GetPreviousEditableHTMLNodeInBlock()` r=m_kato!

Depends on D113280

Comment 76

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 42: Get rid of `HTMLEditor::GetNextEditableHTMLNode()` and `HTMLEditor::GetPreviousEditableHTMLNode()` r=m_kato!

This changes the logic of HTMLEditor::GetFirstEditableLeaf() and
HTMLEditor::GetLastEditableLeaf(), but it shouldn't change actual behavior
because the case is that the first/last child of aNode is not in editing
host but editable.

Depends on D113281

Comment 77

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8134628ba8bf
part 24: Make `EditorBase::FindNode` and `EditorBase::Get*NodeInternal()` take an `EnumSet` instead of multiple `bool` arguments r=m_kato
https://hg.mozilla.org/integration/autoland/rev/54b001545864
part 25: Rename `WalkTreeOption::FindAnyDataNode` to `WalkTreeOption::IgnoreDataNodeExceptText` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/73beaa39972d
part 26: Rename `EditorBase::Get*NodeInternal()` to `Get*Content()` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/38d54b3f0e7e
part 27: Get rid of `EditorBase::GetNextNode()` and `EditorBase::GetPreviousNode()` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/3cc2bc76803d
part 28: Get rid of `EditorBase::GetNextElementOrText()` and `EditorBase::GetPreviousElementOrText()` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/a446dafdd54a
part 29: Get rid of `EditorBase::GetNextElementOrTextInBlock()` and `EditorBase::GetPreviousElementOrTextInBlock()` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/8c688ae2cca9
part 30: Get rid of `EditorBase::GetNextEditableNodeInBlock()` and `EditorBase::GetPreviousEditableNodeInBlock()` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/68e36962f1c8
part 31: Get rid of `EditorBase::GetNextEditableNode()` and `EditorBase::GetPreviousEditableNode()` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/afd4832eef7a
part 32: Get rid of `EditorBase::GetNextNodeInBlock()` and `EditorBase::GetPreviousNodeInBlock()` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/48c21b42fee5
part 33: Make `EditorBase::FindNode()` and `EditorBase::FindNextLeafNode()` static r=m_kato
https://hg.mozilla.org/integration/autoland/rev/952dc69a0c72
part 34: Make `EditorBase::GetNextContent()` and `EditorBase::GetPreviousContent()` static r=m_kato
https://hg.mozilla.org/integration/autoland/rev/c33dc0983218
part 35: Move `EditorBase::GetFirstEditableNode()` into `HTMLEditUtils` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/d2431da8edea
part 36: Make `EditorBase::CreateTransactionForCollapsedRange()` use `EditorBase::GetNextContent()` and `EditorBase::GetPreviousContent()` only when it's an `HTMLEditor` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/e9def24bca26
part 37: Get rid of editor type argument from `EditorBase::GetNextContent()` and `EditorBase::GetPreviousContent()` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/a765064201f8
part 38: Move `EditorBase::GetNextContent()` and `EditorBase::GetPreviousContent()` to `HTMLEditUtils` r=m_kato

Comment 78

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/04d2ac9ad581
part 39: Get rid of `HTMLEditor::GetNextHTMLElementOrTextInBlock()` and `HTMLEditor::GetPreviousHTMLElementOrTextInBlock()` r=m_kato

Comment 79

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0587577e47d
part 40: Get rid of `HTMLEditor::GetNextHTMLElementOrText()` and `HTMLEditor::GetPreviousHTMLElementOrText()` and their internal methods r=m_kato

Comment 80

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/8134628ba8bf
https://hg.mozilla.org/mozilla-central/rev/54b001545864
https://hg.mozilla.org/mozilla-central/rev/73beaa39972d
https://hg.mozilla.org/mozilla-central/rev/38d54b3f0e7e
https://hg.mozilla.org/mozilla-central/rev/3cc2bc76803d
https://hg.mozilla.org/mozilla-central/rev/a446dafdd54a
https://hg.mozilla.org/mozilla-central/rev/8c688ae2cca9
https://hg.mozilla.org/mozilla-central/rev/68e36962f1c8
https://hg.mozilla.org/mozilla-central/rev/afd4832eef7a
https://hg.mozilla.org/mozilla-central/rev/48c21b42fee5
https://hg.mozilla.org/mozilla-central/rev/952dc69a0c72
https://hg.mozilla.org/mozilla-central/rev/c33dc0983218
https://hg.mozilla.org/mozilla-central/rev/d2431da8edea
https://hg.mozilla.org/mozilla-central/rev/e9def24bca26
https://hg.mozilla.org/mozilla-central/rev/a765064201f8

Comment 81

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/04d2ac9ad581
https://hg.mozilla.org/mozilla-central/rev/f0587577e47d

Comment 82

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b33a8402b98c
part 41: Get rid of `HTMLEditor::GetNextEditableHTMLNodeInBlock()` and `HTMLEditor::GetPreviousEditableHTMLNodeInBlock()` r=m_kato

Comment 83

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5cfcc36b7683
part 42: Get rid of `HTMLEditor::GetNextEditableHTMLNode()` and `HTMLEditor::GetPreviousEditableHTMLNode()` r=m_kato

Comment 84

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b33a8402b98c
https://hg.mozilla.org/mozilla-central/rev/5cfcc36b7683

Comment 85

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 43: Move `HTMLEditor::IsVisibleBRElement()` to `HTMLEditUtils::IsVisibleBRElement()` r=m_kato!

Comment 86

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 44: Add `HTMLEditUtils::IsInvisibleBRElement()` for avoiding a mistake r=m_kato!

When I review patches, sometimes I saw wrong usage of !IsVisibleBRElement().
It means that it's an invisible <br> element or non-<br> element node,
but developers may think it checks whether it's an invisible <br> element
or not without checking the specifying content is a <br> element.

For avoiding this, there should be IsInvisibleBRElement() too.

Depends on D114932

Comment 87

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 45: Add helper methods which test found `<br>` element visibility to `WSRunScanner` and `WSScanResult` r=m_kato!

This must make the callers of HTMLEditUtils::IsVisibleBRElement() and
HTMLEditUtils::IsInvisibleBRElement() easier to read.

Depends on D114933

Comment 88

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e027618f6d55
part 43: Move `HTMLEditor::IsVisibleBRElement()` to `HTMLEditUtils::IsVisibleBRElement()` r=m_kato

Comment 89

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bc079cb52514
part 44: Add `HTMLEditUtils::IsInvisibleBRElement()` for avoiding a mistake r=m_kato

Comment 90

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e027618f6d55

Comment 91

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc799cfb8718
part 45: Add helper methods which test found `<br>` element visibility to `WSRunScanner` and `WSScanResult` r=m_kato

Comment 92

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/bc079cb52514

Comment 93

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/dc799cfb8718

Comment 94

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 46: Move `HTMLEditor::GetPriorHTMLSibling()` to `HTMLEditUtils` r=m_kato!

Comment 95

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 47: Move `HTMLEditor::GetNextHTMLSibling()` to `HTMLEditUtils` r=m_kato!

Depends on D115115

Comment 96

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 48: Get rid of `HTMLEditUtils::GetFirstEditableLeafContent()` due to unused r=m_kato!

I realized that it's used only by the dead path because the only caller,
EditorBase::BeginningOfDocument() is overridden by HTMLEditor and
is never called.

Depends on D115116

Comment 97

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 49: Move `HTMLEditor::GetLastEditableChild()` to `HTMLEditUtils` r=m_kato!

Depends on D115117

Comment 98

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 50: Move `HTMLEditor::GetFirstEditableChild()` to `HTMLEditUtils` r=m_kato!

Depends on D115118

Comment 99

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 51: Move `HTMLEditor::IsFirstEditableChild()` to `HTMLEditUtils` r=m_kato!

Depends on D115119

Comment 100

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 52: Move `HTMLEditor::IsLastEditableChild()` to `HTMLEditUtils` r=m_kato!

Depends on D115120

Comment 101

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 53: Rename `HTMLEditUtils::GetFirstLeafChild()` and `HTMLEditUtils::GetLastLeafChild()` r=m_kato!

They may return a descendant, and now HTMLEditUtils has some methods whose
name ends with Child and they scan only direct children of given node.
So, we should rename these methods for avoiding misunderstanding.

Depends on D115121

Comment 102

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 54: Merge `HTMLEditor::Get(First|Last)EditableLeaf()` into `HTMLEditUtils::Get(First|Last)LeafContent()` r=m_kato!

The different points are, whether it checks in a given element or not, and
whether it ignores non-editable content. Therefore, this patch adds new
LeafNodeType and new ancestor limiter argument.

The new flag is not handled in the other methods which take LeafNodeType
because there is no test.

Depends on D115122

Comment 103

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 55: Move `HTMLEditor::IsEmptyInlineNode()` and `HTMLEditor::IsEmptyOneHardLine()` to `HTMLEditUtils` r=m_kato!

Depends on D115123

Comment 104

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 56: Move `HTMLEditor::GetGoodCaretPointFor()` to `HTMLEditUtils` r=m_kato!

Depends on D115164

Comment 105

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 57: Move `HTMLEditor::GetBetterInsertionPointFor()` to `HTMLEditUtils` r=m_kato!

Depends on D115165

Comment 106

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 58: Move `HTMLEditor::IsEmptyBlockElement()` to `HTMLEditUtils` r=m_kato!

Depends on D115166

Comment 107

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 59: Move `HTMLEditor::GetMostAncestorInlineElement()` to `HTMLEditUtils` r=m_kato!

Depends on D115167

Comment 108

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 60: Move `HTMLEditor::GetNearestAncestorListItemElement()` to `HTMLEditUtils` r=m_kato!

Depends on D115168

Comment 109

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 61: Get rid of `HTMLEditor::NodesInDifferentTableElements()` r=m_kato!

Despite its name, it checks whether both given nodes are in same/no table
structure element or not. For avoiding this confusion, let's add
GetInclusiveAncestorAnyTableElement() to HTMLEditUtils and compare
the result of its calls with 2 content nodes.

Depends on D115169

Comment 110

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 62: Get rid of `HTMLEditor::IsPrevCharInNodeWhiteSpace()` r=m_kato!

It's used only by HTMLEditor::GetWhiteSpaceEndPoint() and it just skips
white-spaces and returns first white-space position if and only if the
given point container is a text node and its previous character is a
white-space. Therefore, it can be rewritten with EditorDOMPoint simply in
the caller.

Depends on D115170

Comment 111

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 63: Get rid of `HTMLEditor::IsNextCharInNodeWhiteSpace()` r=m_kato!

Similarly, it's called only by HTMLEditor::GetWhiteSpaceEndPoint() and
it returns after point of last white-space if and only if the given point
container is a text node and the offset is not end of the text node.
Therefore, we can reimplement it in the caller simply.

Depends on D115171

Comment 112

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 64: Get rid of `HTMLEditor::GetWhiteSpaceEndPoint()` r=m_kato!

Now, it does easy things and called only by
HTMLEditor::CreateRangeIncludingAdjuscentWhiteSpaces(). Therefore, we can
move the code into the caller.

Depends on D115172

Comment 113

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c59a870859b2
part 46: Move `HTMLEditor::GetPriorHTMLSibling()` to `HTMLEditUtils` r=m_kato

Comment 114

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 65: Move `HTMLEditor::GetDeepestEditableOnlyChildDivBlockquoteOrListElement()` to `HTMLEditUtils` r=m_kato!

And also HTMLEditor::CountEditableChildren() is moved since it's used only by
it.

Despite the long method name, it's really unclear what it does. I try to
explain it with new name, but the things which the method does are not make
sense. So, if you have better name idea, I'll take it...

Depends on D115173

Comment 115

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 66: Move `HTMLEditor::IsTextPropertySetByContent()` to `HTMLEditUtils` r=m_kato!

Depends on D115177

Comment 116

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 67: Move `HTMLEditor::FindNearEditableContent()` to `HTMLEditUtils` r=m_kato!

Depends on D115178

Comment 117

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1627175 - part 68: Move `HTMLEditor::StartOrEndOfSelectionRangesIsIn()` to `AutoRangeArray` r=m_kato!

Depends on D115179

Comment 118

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa632a8427b0
part 47: Move `HTMLEditor::GetNextHTMLSibling()` to `HTMLEditUtils` r=m_kato

Comment 119

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85aabcbe6fe5
part 48: Get rid of `HTMLEditUtils::GetFirstEditableLeafContent()` due to unused r=m_kato

Comment 120

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f191e2cc4529
part 49: Move `HTMLEditor::GetLastEditableChild()` to `HTMLEditUtils` r=m_kato

Comment 121

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5de53d489b7d
part 50: Move `HTMLEditor::GetFirstEditableChild()` to `HTMLEditUtils` r=m_kato

Comment 122

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4faec743b5f1
part 51: Move `HTMLEditor::IsFirstEditableChild()` to `HTMLEditUtils` r=m_kato

Comment 123

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/480d25550e0f
part 52: Move `HTMLEditor::IsLastEditableChild()` to `HTMLEditUtils` r=m_kato

Comment 124

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67d0fba3df92
part 53: Rename `HTMLEditUtils::GetFirstLeafChild()` and `HTMLEditUtils::GetLastLeafChild()` r=m_kato
https://hg.mozilla.org/integration/autoland/rev/f4f4f32f1270
part 54: Merge `HTMLEditor::Get(First|Last)EditableLeaf()` into `HTMLEditUtils::Get(First|Last)LeafContent()` r=m_kato

Comment 125

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/31e6ee41cd5a
part 55: Move `HTMLEditor::IsEmptyInlineNode()` and `HTMLEditor::IsEmptyOneHardLine()` to `HTMLEditUtils` r=m_kato

Comment 126

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05436a767b5b
part 56: Move `HTMLEditor::GetGoodCaretPointFor()` to `HTMLEditUtils` r=m_kato

Comment 127

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5c77aa7cbc5
part 57: Move `HTMLEditor::GetBetterInsertionPointFor()` to `HTMLEditUtils` r=m_kato

Comment 128

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c59a870859b2
https://hg.mozilla.org/mozilla-central/rev/aa632a8427b0
https://hg.mozilla.org/mozilla-central/rev/85aabcbe6fe5
https://hg.mozilla.org/mozilla-central/rev/f191e2cc4529
https://hg.mozilla.org/mozilla-central/rev/5de53d489b7d

Comment 129

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/4faec743b5f1
https://hg.mozilla.org/mozilla-central/rev/480d25550e0f
https://hg.mozilla.org/mozilla-central/rev/67d0fba3df92
https://hg.mozilla.org/mozilla-central/rev/f4f4f32f1270
https://hg.mozilla.org/mozilla-central/rev/31e6ee41cd5a
https://hg.mozilla.org/mozilla-central/rev/05436a767b5b
https://hg.mozilla.org/mozilla-central/rev/a5c77aa7cbc5

Comment 130

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/734be62c0dbc
part 58: Move `HTMLEditor::IsEmptyBlockElement()` to `HTMLEditUtils` r=m_kato

Comment 131

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40eb2ea58aa7
part 59: Move `HTMLEditor::GetMostAncestorInlineElement()` to `HTMLEditUtils` r=m_kato

Comment 132

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ca3ae12971f
part 60: Move `HTMLEditor::GetNearestAncestorListItemElement()` to `HTMLEditUtils` r=m_kato

Comment 133

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/51c404b61e6c
part 61: Get rid of `HTMLEditor::NodesInDifferentTableElements()` r=m_kato

Comment 134

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a0552785275
part 62: Get rid of `HTMLEditor::IsPrevCharInNodeWhiteSpace()` r=m_kato

Comment 135

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea32cc59ac32
part 63: Get rid of `HTMLEditor::IsNextCharInNodeWhiteSpace()` r=m_kato

Comment 136

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/99e716181ac9
part 64: Get rid of `HTMLEditor::GetWhiteSpaceEndPoint()` r=m_kato

Comment 137

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7ecdf3309563
part 65: Move `HTMLEditor::GetDeepestEditableOnlyChildDivBlockquoteOrListElement()` to `HTMLEditUtils` r=m_kato

Comment 138

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55bb517a4ff5
part 66: Move `HTMLEditor::IsTextPropertySetByContent()` to `HTMLEditUtils` r=m_kato

Comment 139

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3dd600a5fc90
part 67: Move `HTMLEditor::FindNearEditableContent()` to `HTMLEditUtils` r=m_kato

Comment 140

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e72cd321bbaf
part 68: Move `HTMLEditor::StartOrEndOfSelectionRangesIsIn()` to `AutoRangeArray` r=m_kato

Comment 141

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/734be62c0dbc
https://hg.mozilla.org/mozilla-central/rev/40eb2ea58aa7
https://hg.mozilla.org/mozilla-central/rev/8ca3ae12971f
https://hg.mozilla.org/mozilla-central/rev/51c404b61e6c
https://hg.mozilla.org/mozilla-central/rev/6a0552785275
https://hg.mozilla.org/mozilla-central/rev/ea32cc59ac32
https://hg.mozilla.org/mozilla-central/rev/99e716181ac9
https://hg.mozilla.org/mozilla-central/rev/7ecdf3309563
https://hg.mozilla.org/mozilla-central/rev/55bb517a4ff5

Comment 142

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/3dd600a5fc90
https://hg.mozilla.org/mozilla-central/rev/e72cd321bbaf