Closed Bug 162718 Opened 22 years ago Closed 21 years ago

Preview of Preferences/Navigator/Smart Browsing/Advanced is not localisable

Categories

(SeaMonkey :: General, defect)

Product:
SeaMonkey
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: yinglinxia, Assigned: vberon)

References

Details

(Keywords: l12y, Whiteboard: [adt3][browser])

Attachments

(3 files)

screenshot
96.92 KB, image/jpeg
Details
screenshot: a French example from bug 180515
43.37 KB, image/gif
Details
Move the gifs to the language pack
6.70 KB, patch
bryner
: review+
rbs
: superreview+
Details | Diff | Splinter Review
Inside comm.jar, content\communicator\pref, there are 4 autocomplete-xxxx.gif files contains English strings, they should be moved into language pack for localization.
Attached image screenshot —
This comes from bugscape 16704...
Keywords: l12y
QA Contact: asa → ruixu
Status: UNCONFIRMED → NEW
Ever confirmed: true
QA Contact: ruixu → kasumi
nominating nsbeta1 for buffy fix
Keywords: nsbeta1
Another way is to remove the localizable part "Search Netscape Search for 'mo'" in US build.
Blocks: 157673
nsbeta1+adt3 per the nav triage team.
Keywords: nsbeta1 → nsbeta1+
Whiteboard: [adt3]
removing adt3, keeping nsbeta1+ There are images in the file. These images should be text. Images cannot be localizated. Please change the images to text. cc. rebron
Whiteboard: [adt3] → [browser]
*** Bug 180515 has been marked as a duplicate of this bug. ***
re-summeary from bug 180515
Summary: Autocomplete Pref preview image files should be moved into language pack → Preview of Preferences/Navigator/Smart Browsing/Advaced is not localisable.
i18n triage team: nsbeta1+/adt3 Recommendation is to move the gifs out of core to the lang pack.
Whiteboard: [browser] → [adt3][browser]
In addition to the attached patch, the 4 files xpfe/components/prefwindow/resources/content/autocomplete-*.gif must be moved to xpfe/components/prefwindow/resources/locale/en-US/autocomplete-*.gif to fix the bug.
QA Contact: kasumi → marina
Comment on attachment 129256 [details] [diff] [review] Move the gifs to the language pack Requesting review&superreview for attachment #129256 [details] [diff] [review].
Attachment #129256 - Flags: superreview?(rbs)
Attachment #129256 - Flags: review?(hewitt)
Attachment #129256 - Flags: superreview?(rbs) → superreview+
Hewitt is gone. I guess he won't review this anymore.
Summary: Preview of Preferences/Navigator/Smart Browsing/Advaced is not localisable. → Preview of Preferences/Navigator/Smart Browsing/Advanced is not localisable
Comment on attachment 129256 [details] [diff] [review] Move the gifs to the language pack Ok, asking bryner to review and take over then.
Attachment #129256 - Flags: review?(hewitt) → review?(bryner)
Attachment #129256 - Flags: review?(bryner) → review+
Dave, could you move the files?
The files in question have been copied to the new location and all existing tags removed. You will need to cvs delete the ones in the old location when you're done with them.
Comment on attachment 129256 [details] [diff] [review] Move the gifs to the language pack This is a long-outstanding issue for localizers and the fix seems to be pretty low-risk. The files have been copied to the new location in cvs by justdave (see comment 16).
Attachment #129256 - Flags: approval1.7b?
Comment on attachment 129256 [details] [diff] [review] Move the gifs to the language pack a=chofmann for 1.7b
Attachment #129256 - Flags: approval1.7b? → approval1.7b+
Assignee: hewitt → vberon
Fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: